acq.currency_type labels are untranslatable

[Pasi Kallinen]

*EG master

Currency names are untranslatable:

Open-ILS/src/sql/Pg/200.schema.acq.sql:INSERT INTO acq.currency_type (code, label) VALUES ('EUR','Euros');

[Dan Scott (denials)]

Strictly speaking, the bug title is incorrect. Currency labels are translatable, per the "oils_persist:i18n" attribute in fm_IDL.xml:

<fields oils_persist:primary="code">
  <field reporter:label="Currency Code" name="code" reporter:datatype="text" reporter:selector='label'/>
  <field reporter:label="Currency Label" name="label" reporter:datatype="text" oils_persist:i18n="true" />
</fields>

So the realy bug is simply that the seed data in 200.schema.acq.sql should move to 950.data.seed-values.sql and should include the oils_i18n_gettext() marker.

[Pasi Kallinen (paxed)]

Fixed in branch user/paxed/lp1107834

[Remington Steed (rjs7)]

Since this is a simple change, I have only done the basic test of running the SQL inserts in question, and they work as expected. Also, it is my understanding that such a change does not require an upgrade script, because the upgrade process doesn't yet participate in the translation-building process. If this is true, then perhaps we should open a bug to address this.

Signed off and rebased to master. Thanks Pasi!

user/rsteed/lp1107834_more_acq_i18n_seed_data
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1107834_more_acq_i18n_seed_data

[Dan Wells (dbw2)]

Because currency_type is a foreign key of acq.exchange_rate, if we move currency_type to the seed data file, exchange rate must follow. Are there more dominoes in this chain?

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1107834_more_acq_i18n_seed_data

working/user/dbwells/lp1107834_more_acq_i18n_seed_data

[Dan Wells (dbw2)]

Double-checked, database seems to build fine with the latest commit.

[Ben Shum (bshum)]

Picked to master. Thanks Pasi, Remington, and Dan!