Use <AxesColor> as the fallback if no <Color> is present
Bug #1107163 reported by
Daniel Schürmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Wishlist
|
Daniel Schürmann | ||
Bug Description
This was proposed by RJ in Bug #1099182.
Doing this, we can get rid of <MarkerColor>
Related branches
| Changed in mixxx: | |
| status: | New → In Progress |
| importance: | Undecided → Wishlist |
| assignee: | nobody → Daniel Schürmann (daschuer) |
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #1 |
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #2 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #3 |
| Changed in mixxx: | |
| milestone: | none → 1.11.0 |
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #4 |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #5 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
It's not a big issue to change the code like that. But I am not sure how to deal with legacy skins.
If you look at Deere 1280 for instance it has
<MarkerColor>
<AxesColor>
AxesColor default is hard coded to QColor(
In this case legacy skin without a <Color></Color> tag would have a different mark color after fixing this bug.
For me, this effect is acceptable, what do you think?