Use <AxesColor> as the fallback if no <Color> is present
Bug #1107163 reported by
Daniel Schürmann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Wishlist
|
Daniel Schürmann |
Bug Description
This was proposed by RJ in Bug #1099182.
Doing this, we can get rid of <MarkerColor>
Related branches
Changed in mixxx: | |
status: | New → In Progress |
importance: | Undecided → Wishlist |
assignee: | nobody → Daniel Schürmann (daschuer) |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It's not a big issue to change the code like that. But I am not sure how to deal with legacy skins.
If you look at Deere 1280 for instance it has
<MarkerColor> #00FF00< /MarkerColor> </AxesColor>
<AxesColor>
AxesColor default is hard coded to QColor( 245,245, 245);
In this case legacy skin without a <Color></Color> tag would have a different mark color after fixing this bug.
For me, this effect is acceptable, what do you think?