kwapi pollster does not disable itself when kwapi is not running

Bug #1105404 reported by Sandy Walsh
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Mehdi Abaakouk

Bug Description

In a vanilla devstack install (with CM enabled obviously), the kwapi pollster errors out on startup.

http://paste.openstack.org/show/29839/

Changed in ceilometer:
status: New → Confirmed
summary: - kwapi pollster is enabled in vanilla install (devstack)
+ kwapi pollster does not disable itself when kwapi is not running
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

It probably produces that same error each time the pollsters are queried. It should implement the is_enabled() method to look for the endpoint and return False if it isn't configured, so the pollster is taken out of the rotation.

Revision history for this message
jiang, yunhong (yunhong-jiang) wrote :

I'm not sure if we really want to take the pollster out of the rotation if the endpoint does not exist. For example, possibly that service is not started yet when ceilometer starting, , and later that service is started.

For this KWAPI specific issue, I'd suggest to disable it by default in the configuration in devstack environment, so that it will not give such confusing warning.

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Well, you know this is the crux of my concern with the Stevedore deployment model. Explicit is better than implicit. I should explicitly have to state what drivers I want loaded and not get surprised by stuff firing up simply because it's installed.

To limit it just for devstack, I think, is skirting the issue.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Unless kwapi is going to become a standard part of OpenStack, it should disable itself automatically. If it depends on having the endpoint registered to work, then that's a clean way to detect for itself whether or not it should be enabled. That logic should apply whether devstack is being used or not, since the place we really don't want the extra warnings is in a production deployment where looking at the log files for useful information is even more important than in development.

Changed in ceilometer:
milestone: none → grizzly-rc1
importance: Undecided → Medium
Mehdi Abaakouk (sileht)
Changed in ceilometer:
assignee: nobody → Mehdi Abaakouk (sileht)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23544

Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/23544
Committed: http://github.com/openstack/ceilometer/commit/fba1ae00c324d9ad9ec0e6700ed317832e9e58e0
Submitter: Jenkins
Branch: master

commit fba1ae00c324d9ad9ec0e6700ed317832e9e58e0
Author: Mehdi Abaakouk <email address hidden>
Date: Tue Mar 5 13:29:39 2013 +0100

    Kwapi pollster silently return no probre if keystone endpoint is not present

    Fixes bug 1105404

    Change-Id: Ib2673215ca1075d04283492d9e08540f9f786d08

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.