TPAC "green" button enhancement

Bug #1102934 reported by Pasi Kallinen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

In Finnish there is no widely-used acronym for "Frequently Asked Questions" - In the OPAC login screen, the FAQ-button tries to wrap into multiple lines, and will look ugly. See image.

This will allow for multi-line buttons, and also fixes a minor inconsistency with the green OPAC buttons: Some of them did not change shade when hovering with mouse.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/multiline_opac_buttons

Revision history for this message
Pasi Kallinen (paxed) wrote :
Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
importance: Medium → Wishlist
milestone: none → 2.4.0-alpha
Revision history for this message
Dan Scott (denials) wrote :

Looks good to me. Pushed to master, after squashing down to a single commit to keep the repository history reasonably clean. Thanks Pasi!

Changed in evergreen:
status: Triaged → Fix Committed
Revision history for this message
Ben Shum (bshum) wrote :

Re-opening this bug to add one tiny final tweak. Changing the block to inline-block for the new opac-multiline-button style helps to balance out long text vs. short text and shrink the button to fit appropriately based on what text is contained in the button. This helps address a concern that "FAQs" (the default english text) still had a giant button shape around it to fill the whole div space.

See branch: working/user/bshum/multiline-css

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/multiline-css

Changed in evergreen:
status: Fix Committed → Confirmed
milestone: 2.4.0-alpha1 → 2.4.0-rc
Revision history for this message
Kyle Tomita (tomitakyle) wrote :

I verified this fix by changing the text from "FAQs" to "Frequently Asked Questions".

Here is my signoff branch, http://git.evergreen-ils.org/?p=working/Evergreen.git;a=log;h=refs/heads/user/catalystit/bshum/multiline-css-signoff

tags: added: signedoff
Revision history for this message
Kyle Tomita (tomitakyle) wrote :
Revision history for this message
Ben Shum (bshum) wrote :

Thanks for the sign off Kyle. Pushed to master for inclusion in 2.4 to complete this feature.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.