Job creation via Active MQ doesn't populate all occurences of the same field

[Matthias Ronge]

The Active MQ interface was written in belief that each labelled field would only be present once. This isn't true in all cases, and creating new processes may fail if there are multiple instances of the same field.

[Matthias Ronge (matthias-ronge)]

Bug fix:

https://github.com/matthias-ronge/bug-1102401

[Matthias Ronge (matthias-ronge)]

Merge request:

https://github.com/goobi/goobi-production/pull/1

[Ralf Claussnitzer (ralf-claussnitzer-deactivatedaccount)]

This looks like a workaround for a design issue. What is the use of having the same {key, value} pair multiple times? This should be implemented as a map. Can we do this? Or is this all hidden somewhere in UGH?

Where do "multiple instances of the same field" come from?
Where is this a feature?
When is this situation an actual problem?

[Matthias Ronge (matthias-ronge)]

This is about ProzesskopieForm’s private List<AdditionalField> additionalFields

Examining the list entries shows that, for the AdditionalField with titel="Titel" there are two entries, one of them with isnotdoctype="multivolume" and the other one with isdoctype="multivolume". They are generated from examining projects.xml, which reads:

<!-- Title for Monograph and Periodical -->
<item docstruct="topstruct" from="vorlage" isnotdoctype="multivolume"
 metadata="TitleDocMain" required="true" ughbinding="true"> Titel </item>
[...]
<!-- Title just for the Multivolume -->
<item docstruct="topstruct" from="vorlage" isdoctype="multivolume"
 metadata="TitleDocMain" required="true" ughbinding="true"> Titel </item>

It seems Goobi generates all possible cases and, on switching the docType, only changes which ones to show. Changing this to a Map would also mean that this initialization process would be needed to be rewritten to re-initalize the map whenever one changes the docType.

[Ralf Claussnitzer (ralf-claussnitzer-deactivatedaccount)]

Thanks for clarification. By reading the parameter names (String key, String value) one might think of map, but appearently, "key" is looks like a n-tuple.

[Matthias Ronge (matthias-ronge)]

Branch has moved here:
https://github.com/matthias-ronge/goobi-production/tree/bug-1102401