Coverity FORWARD_NULL - CID 12446 - plugins/animation/src/animation.cpp - in function: PrivateAnimScreen::initiateFocusAnim(PrivateAnimWindow *) - Dynamic cast to pointer "dynamic_cast <RestackAnim *>(aw->mCurAnimation)" can return NULL. Passing null pointer "dynamic_cast <RestackAnim *>(aw->mCurAnimation)" to function "RestackAnim::initiateRestackAnim(int)", which dereferences it.

Bug #1101506 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Triaged
Medium
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12446
Checker: FORWARD_NULL
Category: dynamic_cast
CWE definition: http://cwe.mitre.org/data/definitions/476.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/animation.cpp
Function: PrivateAnimScreen::initiateFocusAnim(PrivateAnimWindow *)
Code snippet:
2378 if (chosenEffect != AnimEffectNone)
2379 {
2380 aw->createFocusAnimation (chosenEffect, duration);
2381
CID 12446 - FORWARD_NULL
Dynamic cast to pointer "dynamic_cast <RestackAnim *>(aw->mCurAnimation)" can return NULL.
Passing null pointer "dynamic_cast <RestackAnim *>(aw->mCurAnimation)" to function "RestackAnim::initiateRestackAnim(int)", which dereferences it.
2382 if (chosenEffect->isRestackAnim &&
2383 !(dynamic_cast<RestackAnim *> (aw->mCurAnimation)->
2384 initiateRestackAnim (duration)))
2385 {
2386 aw->postAnimationCleanUp ();
2387 return false;

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/animation.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → High
MC Return (mc-return)
summary: - Coverity FORWARD_NULL - CID 12446
+ Coverity FORWARD_NULL - CID 12446 - plugins/animation/src/animation.cpp
+ - in function: PrivateAnimScreen::initiateFocusAnim(PrivateAnimWindow *)
+ - Dynamic cast to pointer "dynamic_cast <RestackAnim
+ *>(aw->mCurAnimation)" can return NULL. Passing null pointer
+ "dynamic_cast <RestackAnim *>(aw->mCurAnimation)" to function
+ "RestackAnim::initiateRestackAnim(int)", which dereferences it.
Changed in compiz:
milestone: none → 0.9.10.0
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.0 → 0.9.11.0
Stephen M. Webb (bregma)
no longer affects: compiz/0.9.9
Changed in compiz:
status: New → Triaged
importance: High → Medium
milestone: 0.9.11.0 → 0.9.12.0
Stephen M. Webb (bregma)
Changed in compiz:
milestone: 0.9.12.0 → 0.9.12.1
Stephen M. Webb (bregma)
Changed in compiz:
milestone: 0.9.12.1 → 0.9.12.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.