Coverity CHECKED_RETURN - CID 12391 - plugins/animation/src/options.cpp - in function: PrivateAnimScreen::getOptionSetForSelectedRow(PrivateAnimWindow *, Animation *) - Calling function "Animation::curWindowEvent()" without checking return value (as is done elsewhere 16 out of 18 times). No check of the return value of "anim->curWindowEvent()".

Bug #1101489 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
New
Medium
Unassigned
0.9.9
New
Medium
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12391
Checker: CHECKED_RETURN
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/252.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/options.cpp
Function: PrivateAnimScreen::getOptionSetForSelectedRow(PrivateAnimWindow *, Animation *)
Code snippet:
115 OptionSet *
116 PrivateAnimScreen::getOptionSetForSelectedRow (PrivateAnimWindow *aw,
117 Animation *anim)
118 {
CID 12391 - CHECKED_RETURN
Calling function "Animation::curWindowEvent()" without checking return value (as is done elsewhere 16 out of 18 times).
No check of the return value of "anim->curWindowEvent()".
119 const AnimEvent event = win2AnimEventMap[anim->curWindowEvent ()];
120 OptionSets &eventOptionSets = mEventOptionSets[event];
121 OptionSet *setSelectedForRow = &eventOptionSets.sets[(unsigned int) aw->curAnimSelectionRow ()];
122
123 return setSelectedForRow;
124 }

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/options.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → Medium
MC Return (mc-return)
Changed in compiz:
milestone: none → 0.9.10.0
summary: - Coverity CHECKED_RETURN - CID 12391
+ Coverity CHECKED_RETURN - CID 12391 - plugins/animation/src/options.cpp
+ - in function:
+ PrivateAnimScreen::getOptionSetForSelectedRow(PrivateAnimWindow *,
+ Animation *) - Calling function "Animation::curWindowEvent()" without
+ checking return value (as is done elsewhere 16 out of 18 times). No
+ check of the return value of "anim->curWindowEvent()".
Changed in compiz:
milestone: 0.9.10.0 → 0.9.10.2
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.2 → 0.9.11.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.