[apport] gnome-settings-daemon crashed with SIGSEGV

[saurav]

segment violation after upgrading to feisty

ProblemType: Crash
Architecture: i386
Date: Tue Apr 24 13:51:07 2007
Disassembly: 0xb6527bf0:
DistroRelease: Ubuntu 7.04
ExecutablePath: /usr/lib/control-center/gnome-settings-daemon
Package: gnome-control-center 1:2.18.1-0ubuntu2
PackageArchitecture: i386
ProcCmdline: /usr/lib/control-center/gnome-settings-daemon
ProcCwd: /
ProcEnviron:
 LANGUAGE=en_US.UTF-8
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
 LANG=en_US.UTF-8
 SHELL=/bin/bash
Signal: 11
SourcePackage: control-center
Stacktrace: #0 0xb6527bf0 in ?? ()
StacktraceTop: ?? ()
ThreadStacktrace:

Uname: Linux ngn-pc2 2.6.20-15-386 #2 Sun Apr 15 07:34:00 UTC 2007 i686 GNU/Linux
UserGroups: adm admin audio cdrom dialout dip disk floppy lpadmin plugdev scanner src video

[Apport retracing service (apport)]

StacktraceTop:?? ()

[Daniel Holbach (dholbach)]

Thanks for your bug report. Can you reproduce the crash somehow?

[saurav (saurav-sarkar)]

Yes. If I run gnome-settings-daemon manually, it crashes everytime.

[Chad Miller (cmiller)]

See my comment at the end of Bug#61381.

[Chad Miller (cmiller)]

--- gnome-settings-daemon/gnome-settings-dbus.c-orig 2007-05-01 15:49:23.000000000 -0400
+++ gnome-settings-daemon/gnome-settings-dbus.c 2007-05-01 15:47:44.000000000 -0400
@@ -221,9 +221,13 @@
        if (!org_freedesktop_DBus_request_name
            (driver_proxy, "org.gnome.SettingsDaemon", 0, &request_ret,
             &error)) {
- g_warning ("Unable to register service: %s",
- error->message);
- g_error_free (error);
+ if (error != NULL) {
+ g_warning ("Unable to register service: %s",
+ error->message);
+ g_error_free (error);
+ } else {
+ g_warning ("Unable to register service because of unknown DBUS error");
+ }
        }

        g_object_unref (driver_proxy);

[Chad Miller (cmiller)]

That is reproducable when the user-session "dbus-daemon" isn't running.

[Sebastien Bacher (seb128)]

Chad, thank you for the work on that. Could you give some explanations on the crash, why it's happening and what your change is doing?

[Chad Miller (cmiller)]

Hi Seb. IIRC, I think the bug is really in the dbus library, in that it claims to create an 'error', but instead returns an exceptional value and yet doesn't set error to point to something other than NULL. So, there's probably a bug in dbus.

This patch makes gnome-settings-daemon check that 'error' is actually set to something before trying to use it. It's purely a defensive measure against dbus doing something unexpected. If it happens, we should perhaps make a loud noise also, but we should never crash because of it.

[Sebastien Bacher (seb128)]

I've sent those comments upstream on http://bugzilla.gnome.org/show_bug.cgi?id=439208, do you have an easy way to trigger the crash? It doesn't happen when there is no dbus-daemon started by the user

[Sebastien Bacher (seb128)]

the bug has been fixed upstream now

[Sebastien Bacher (seb128)]

This upload fixes the bug:

 gnome-control-center (1:2.19.3-0ubuntu1) gutsy; urgency=low
 .
   * New upstream version:
     about-me:
     - Use g_file_set_contents instead of a single fwrite
     - Set default permission of ~/.face to 0644
     accessibility:
     - Set button images via code instead of relying on Glade, so they respect
       the gtk-button-images xsetting
     appearance:
     - New capplet to group appearance Settings
     at-properties:
     - Fix critical warning
     - Set button images via code instead of relying on Glade, so they respect
       the gtk-button-images xsetting
     background:
     - After removing a wallpaper, select the next one in the list instead
       of always going to "No Wallpaper" (LP: #109106)
     control center:
     - Removed superfluous X-SuSE translate tag
     display:
     - Survive XRandR returning weird results for some dual-screen setups
     keybindings:
     - Add a noarch pkgconfig file to allow apps to know where to add their
       keybindings
     - Fix keysdir substitution
     - Added g_thread_init as required by glib
     keyboard:
     - Set button images via code instead of relying on Glade, so they respect
       the gtk-button-images xsetting (LP: #66444)
     - Added vendor list to the box, if any
     - Make buildable with libxklavier 3.2
     mouse:
     - Port from deprecated GtkOptionMenu to GtkComboBox
     settings daemon:
     - More refactoring of loadable modules
     - Use "eject -T" as the default eject command
     - Double-check that DBUS really passed an error
     - Sync libegg modules
     - Set the device property to the correct value before opening the mixer
     sound:
     - Use g_timeout_add/remove instead of deprecated GTK versions
     - Set non-0 pulse step for the progress bar to actually make it move
       (LP: #116828)
     theme switcher:
     - Fix memory leaks
     themus:
     - Use OnlyShowIn property to not list Themus in the menu editor
     general:
     - Add GConfPropertyEditor support for GtkComboBox
     - Add support for unsetting GConf values if the conversion handlers return
       null
     - Constify a number of function arguments
     - Add a property editor for GtkTreeView and fix crashes with all peditors
       if the requested key is not available
     - Don't call gconf_value_free with a NULL value
     - Recognize both "gtk-color-scheme" and "gtk_color_scheme"
   * debian/capplets-data.install, debian/libgnome-settings-daemon-dev.install:
     - updated for the new version
   * debian/patches/10_eggaccelerators.patch:
     - dropped, fixed with the new version
   * debian/patches/24_theme_dont_require_metacity.patch:
     - dropped, deprecated with the new version
   * debian/patches/34_at_properties_onboard_and_new_interface.patch:
     - dropped, not compatible with upstream changes
   * debian/patches/81_get_rid_of_orca_main_window.patch:
     - dropped, doesn't apply to new upstream code
   * debian/patches/90_workaround_gnome_doc_utils_bug.patch:
     - dropped, fixed with the new version