Coverity CHECKED_RETURN - CID 12401 - plugins/workarounds/src/workarounds.cpp - in function: WorkaroundsWindow::minimize() - Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere). No check of the return value of "propTemplate.at(0UL)->set(enabled)".

Bug #1101438 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
New
Medium
Unassigned
0.9.9
New
Medium
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12401
Checker: CHECKED_RETURN
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/252.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/workarounds/src/workarounds.cpp
Function: WorkaroundsWindow::minimize()
Code snippet:
210 XChangeProperty (screen->dpy (), window->id (),
211 Atoms::wmState, Atoms::wmState,
212 32, PropModeReplace, (unsigned char *) data, 2);
213
CID 12401 - CHECKED_RETURN
Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times).
No check of the return value of "propTemplate.at(0UL)->set(enabled)".
214 propTemplate.at (0).set (enabled);
215 ws->inputDisabledAtom.updateProperty (window->id (),
216 propTemplate,
217 XA_CARDINAL);
218
219

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/workarounds/src/workarounds.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → Medium
MC Return (mc-return)
summary: - Coverity CHECKED_RETURN - CID 12401
+ Coverity CHECKED_RETURN - CID 12401 -
+ plugins/workarounds/src/workarounds.cpp - in function:
+ WorkaroundsWindow::minimize() - Calling function
+ "CompOption::set(CompOption::Value &)" without checking return value (as
+ is done elsewhere). No check of the return value of
+ "propTemplate.at(0UL)->set(enabled)".
Changed in compiz:
milestone: none → 0.9.10.0
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.0 → 0.9.11.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.