coverage extension should be disabled by default

Bug #1101057 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Dan Prince

Bug Description

Using the latest version of Nova grizzly I'm seeing the following exception in Nova's api.log file:

2013-01-17 21:56:48.519 30407 WARNING nova.api.openstack.compute.contrib [-] Failed to load extension nova.api.openstack.compute.contrib.coverage_ext.Coverage_ext: No module named coverage

====

Clearly the coverage extension is for testing only... but it seems to be enabled by default?

At the very least we should handle the missing 'coverage' import since it is only a tools/test-requires (and would not be good to force users to install in production).

Probably the *best* thing to do here would be to disable the coverage extension by default (production ready should be the default). Users can then enable it specifically for testing purposes if they desire.

Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Dan Prince (dan-prince) wrote :

Okay. Trying to avoid adding a new config option here perhaps we can just avoid the hard dependency on the 'coverage' module.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20571

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/20571
Committed: http://github.com/openstack/nova/commit/2ca9553d7c5b4f244532caaa9219d1a8d560284b
Submitter: Jenkins
Branch: master

commit 2ca9553d7c5b4f244532caaa9219d1a8d560284b
Author: Dan Prince <email address hidden>
Date: Sun Jan 27 17:57:56 2013 -0500

    Avoid hard dependency on python-coverage.

    Updates the coverage extension in the OpenStack Compute API to
    avoid a hard dependency on the python coverage module. We now
    try to import 'coverage' and if it isn't present we return
    an HTTP 503 (service unavailable error).

    This gets rid of WARNING errors which occur when running Nova API
    when the 'coverage' module is not available:

    2013-01-27 17:10:28.938 16018 WARNING nova.api.openstack.compute.contrib
    [-] Failed to load extension
    nova.api.openstack.compute.contrib.coverage_ext.Coverage_ext: No module
    named coverage

    Fixes LP Bug #1101057.

    Change-Id: I573180aead44d68b8377cd66f30fc6ac849d0272

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.