Instance fault when rescheduling is missing exception info

Bug #1100559 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Rick Harris

Bug Description

Currently the _reschedule_or_reraise function in compute/manager is passed exc_info[0] as the `fault`. Since this is a `type` not an exception object, we end up with a repr of `type` which isn't very helpful in debugging.

The solution is to pass the exception as the fault as is done elsewhere in the code.

Changed in nova:
importance: Undecided → High
assignee: nobody → Rick Harris (rconradharris)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/19888

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19877
Committed: http://github.com/openstack/nova/commit/724081adc450a900a6c1ba97e2d1d61748e30d4f
Submitter: Jenkins
Branch: master

commit 724081adc450a900a6c1ba97e2d1d61748e30d4f
Author: Rick Harris <email address hidden>
Date: Thu Jan 17 03:09:43 2013 +0000

    Better instance fault message when rescheduling.

    The old code would use exc_info[0] which is the type of exception, not
    the exception itself. This would result in the `message` attribute
    always being 'type' and the first-line of details being useless.

    The solution is to pass the actual exception object so that `message`
    becomes the class-name and the first-line of details becomes the `repr`
    of the exception object.

    Fixes bug 1100559

    Change-Id: Ibaeb5dc5af419de6c98b44aec07bff225b2f9956

Changed in nova:
status: In Progress → Fix Committed
tags: added: folsom-backport-potential
tags: removed: folsom-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.