Detected wrong encoding and so saved [$50]

[Hlobil Vaclav]

Hi,

there's a critical (as it corrupts data) bug in Scratch. I have documents in Central European (WIN-1250) encoding. Scratch detects wrong encoding of this files while opening. There are some russian chars instead of czech ones. And as I change only one char in opened document, it is saved in that wrong encoding. And because there are not backups created on save, and autosave is activated in default state, it's very easy to lost correct version of document.

Maybe it's hard to detect right encoding or there is a problem in some related library, because some other editors (gedit...) detect wrong encoding too. But gedit has no autosave and also I can select right encoding in open file dialog.

Also sometimes Scratch opens empty file, when it's not in Latin-1 encoding.

Scratch isn't usable for me in this situations, so I'm forced to use gedit.

---

For testing, I created correct WIN-1250 document with some czech characters. It's in attachment. There's also screenshot showing how it should look.

[Hlobil Vaclav (vaclav-hlobil)]

It's even worse than I thought. As I found out, file with wrong encoding is saved by Scratch immediately after opening. I don't have to write even a single char and file is saved. So the file data are already destroyed when you view it only. Look at next attachments.

[Olivier Duchateau (duchateau-olivier)]

This bug affects also FreeBSD users, when UTF-8 is not default encoding system. Personnaly I use this patch, which try to use current locale, and if it fails previous function.

Without this patch, Scratch can't open any files (my system use ISO-8859-15).

[Cody Garver (codygarver)]

Olivier, your patch no longer applies cleanly, some work has been done to that area of the code. Do the changes resolve this issue? If not, can you provide an updated patch?

[Robert Roth (evfool)]

FYI: the changes in trunk did not resolve this issue, so this is still a valid issue.

[quassy (quassy)]

"And because there are not backups created on save, and autosave is activated in default state, it's very easy to lost correct version of document."
Regardless of the encoding problem discussed here, I think this does qualify as a bug alone. Any app should always present an undo option and that has to include the original unaltered file.

[Danielle Foré (danrabbit)]

https://www.bountysource.com/issues/1423034-detected-wrong-encoding-and-so-saved