OpenStack Compute (nova)

Libvirt driver misses out some CPU flags on old libvirt

Bug #1099527 reported by Daniel Berrange
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Daniel Berrange
OpenStack Compute (nova) 2013.1 "grizzly"
Folsom
Fix Released
High
Daniel Berrange
OpenStack Compute (nova) 2012.2.3

Bug Description

When running against an libvirt < 0.9.10 (which lacks support for the 'host-model' CPU type), we must fake it by copying the host CPU model and features. Unfortunately the code was forgetting to append the new features to the CPU object feature list. The guest was thus given an inaccurate CPU with a subset of the features it should have had

OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Daniel Berrange (berrange)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19099
Committed: http://github.com/openstack/nova/commit/82b55c97d10a55e6a825261397816f6a7ad00fd7
Submitter: Jenkins
Branch: master

commit 82b55c97d10a55e6a825261397816f6a7ad00fd7
Author: Daniel P. Berrange <email address hidden>
Date: Mon Dec 17 15:35:06 2012 +0000

    Fix addition of CPU features when running against legacy libvirt

    When running against an libvirt < 0.9.10 which lacks support for the
    'host-model' CPU type, we must fake it by copying the host CPU
    model and features. Unfortunately the code was forgetting to
    append the new features to the CPU object feature list

    Bug: 1099527
    Change-Id: I39c6df6e85d77763ad279961fd6f0da70ac2415e
    Signed-off-by: Daniel P. Berrange <email address hidden>

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/19658

Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/19658
Committed: http://github.com/openstack/nova/commit/1789d2604312e0e9f8c25918d0d0029586829797
Submitter: Jenkins
Branch: stable/folsom

commit 1789d2604312e0e9f8c25918d0d0029586829797
Author: Daniel P. Berrange <email address hidden>
Date: Mon Dec 17 15:35:06 2012 +0000

    Fix addition of CPU features when running against legacy libvirt

    When running against an libvirt < 0.9.10 which lacks support for the
    'host-model' CPU type, we must fake it by copying the host CPU
    model and features. Unfortunately the code was forgetting to
    append the new features to the CPU object feature list

    Bug: 1099527
    Signed-off-by: Daniel P. Berrange <email address hidden>
    (cherry picked from commit 82b55c97d10a55e6a825261397816f6a7ad00fd7)

    Change-Id: Ib5e6a173f1ae7d421435af45bf327f5b36c94dd0

Mark McLoughlin (markmc)
Changed in nova:
milestone: none → 2012.2.3
Mark McLoughlin (markmc)
Changed in nova:
milestone: 2012.2.3 → none
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.