Bug in NovaBase.save() method

Bug #1098692 reported by Boris Pavlovic
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Boris Pavlovic

Bug Description

There is a bug in sqlalchemy with eventlet that doesn't allows us to use
session.flush() without explicit transaction.

https://bitbucket.org/which_linden/eventlet/issue/118/exceptions-are-cleared-during

If somethings went worng in DB and rollback is called it will raise NoneType exception instead of sqlalchemy exception.

Changed in nova:
status: New → Fix Committed
assignee: nobody → Boris Pavlovic (boris-42)
Changed in nova:
importance: Undecided → High
status: Fix Committed → In Progress
tags: added: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19449
Committed: http://github.com/openstack/nova/commit/ac8b949706b8d0eb0a83193e0187f63dd7ee3225
Submitter: Jenkins
Branch: master

commit ac8b949706b8d0eb0a83193e0187f63dd7ee3225
Author: Boris Pavlovic <email address hidden>
Date: Fri Jan 11 07:01:25 2013 +0400

    Fix error in NovaBase.save() method

    There is a bug in sqlalchemy with eventlet that doesn't allows us to use
    session.flush() without explicit transaction.
    If somethings went wrong in DB and rollback is called it will try to
    raise NoneType.

    I found only one way to handle this situation.
    We should start transaction (or subtransaction if it already exists in session)
    explicitly.

    Fixes bug 1098692

    Change-Id: I12cd643500e341a013cd7c963cb5d1a0106c7940

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote :

Do not mark FixReleased until it's shipped into a milestone... that will be done automatically

Changed in nova:
status: Fix Released → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.