Bug in NovaBase.save() method
Bug #1098692 reported by
Boris Pavlovic
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Boris Pavlovic |
Bug Description
There is a bug in sqlalchemy with eventlet that doesn't allows us to use
session.flush() without explicit transaction.
https:/
If somethings went worng in DB and rollback is called it will raise NoneType exception instead of sqlalchemy exception.
Changed in nova: | |
status: | New → Fix Committed |
assignee: | nobody → Boris Pavlovic (boris-42) |
Changed in nova: | |
importance: | Undecided → High |
status: | Fix Committed → In Progress |
tags: | added: folsom-backport-potential |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | none → grizzly-3 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | grizzly-3 → 2013.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/19449 github. com/openstack/ nova/commit/ ac8b949706b8d0e b0a83193e0187f6 3dd7ee3225
Committed: http://
Submitter: Jenkins
Branch: master
commit ac8b949706b8d0e b0a83193e0187f6 3dd7ee3225
Author: Boris Pavlovic <email address hidden>
Date: Fri Jan 11 07:01:25 2013 +0400
Fix error in NovaBase.save() method
There is a bug in sqlalchemy with eventlet that doesn't allows us to use
session.flush() without explicit transaction.
If somethings went wrong in DB and rollback is called it will try to
raise NoneType.
I found only one way to handle this situation.
We should start transaction (or subtransaction if it already exists in session)
explicitly.
Fixes bug 1098692
Change-Id: I12cd643500e341 a013cd7c963cb5d 1a0106c7940