checking moved instances in init_host() calls method with wrong args

Bug #1097987 reported by Chris Behrens
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Behrens

Bug Description

458 bdi = self._get_instance_volume_block_device_info(context,
 459 instance['uuid'])

in compute manager:

That method wants an instance, not a uuid.

Chris Behrens (cbehrens)
Changed in nova:
importance: Undecided → Medium
status: New → Triaged
Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19352

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19352
Committed: http://github.com/openstack/nova/commit/d25991b41b5f476c293a6cf62361b115a160c64a
Submitter: Jenkins
Branch: master

commit d25991b41b5f476c293a6cf62361b115a160c64a
Author: Chris Behrens <email address hidden>
Date: Thu Jan 10 01:18:33 2013 +0000

    Fix init_host checking moved instances

    Commit 6fc00d3465185 (https://review.openstack.org/#/c/18486/)
    introduced a couple of problems.

    1) It introduced a method to try to deduce instance integer id from
       a name the driver reports and using instance_name_template. This
       fails badly when you're using something like 'instance-%(uuid)s' for
       instance_name_template. It's only used when the driver does not
       support the 'list_instance_uuids' method.. but XenAPI happens to
       not implement this method.

    2) There's a call to _get_instance_volume_block_device_info() that is
       passing an instance_uuid when the method wants an instance.

    Fixes bug 1097987 (#1 above) by doing a brute force match against
       all instances' names.
    Fixes bug 1097978 (#2 above)

    Change-Id: I2da7658dd906fa06f0e867a2b22bf14e7f34cb12

Changed in nova:
status: In Progress → Fix Committed
Chris Behrens (cbehrens)
Changed in nova:
milestone: none → grizzly-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/19406

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/19406
Committed: http://github.com/openstack/nova/commit/d355a45694ffbdd7955f26e1d806bd5244933e90
Submitter: Jenkins
Branch: milestone-proposed

commit d355a45694ffbdd7955f26e1d806bd5244933e90
Author: Chris Behrens <email address hidden>
Date: Thu Jan 10 01:18:33 2013 +0000

    Fix init_host checking moved instances

    Commit 6fc00d3465185 (https://review.openstack.org/#/c/18486/)
    introduced a couple of problems.

    1) It introduced a method to try to deduce instance integer id from
       a name the driver reports and using instance_name_template. This
       fails badly when you're using something like 'instance-%(uuid)s' for
       instance_name_template. It's only used when the driver does not
       support the 'list_instance_uuids' method.. but XenAPI happens to
       not implement this method.

    2) There's a call to _get_instance_volume_block_device_info() that is
       passing an instance_uuid when the method wants an instance.

    Fixes bug 1097987 (#1 above) by doing a brute force match against
       all instances' names.
    Fixes bug 1097978 (#2 above)

    Change-Id: I2da7658dd906fa06f0e867a2b22bf14e7f34cb12
    (cherry picked from commit d25991b41b5f476c293a6cf62361b115a160c64a)

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.