fix default hori/vert frame anchor during RTF import

[Björn Michaelsen]

on LibreOffice 3.5, see fdo#48442 for details

[Mikhail Gavrilov (mikegav)]

Created attachment 59652
problem file

Incorrect displaying attached rtf document

[Mikhail Gavrilov (mikegav)]

Created attachment 59653
Example right displaying in ms word

[Wugs (wugs)]

[REPRODUCIBLE] with LibreOffice 3.5.2.2 (Build-ID: 281b639-6baa1d3-ef66a77-d866f25-f36d45f) German running on MacOS X 10.6.8 German. The page layout is destroyed. I will attach a screenshot showing how the RTF file looks for me in Writer.

[Wugs (wugs)]

Created attachment 60221
Screenshot of the sample document opened with LibreOffice 3.5.2.2 on MacOS X

[Wugs (wugs)]

Lowering severity a bit because there is no data loss, no crash, ...

@Miklos Vajna:
I think this bug may be of interest for you ;-) Therefore I took the liberty to assign it to you, just as a proposal. Please feel free to reassign (or reset Assignee to default) if it’s not your area or if provided information is not sufficient. Please set Status to ASSIGNED if you accept this Bug. Thank you very much!

[Wugs (wugs)]

Created attachment 60240
Screenshot of the sample document opened with master (LOdev)

Tested again with LOmaster 3.6.0alpha0+, Build ID: 55823d3 (installation file: master~2012-04-14_05.23.05_LibO-Dev_3.6.0alpha0_MacOS_x86_install_en-US.dmg) on MacOS X. There is some progress in displaying the page layout, but some elements are still at the wrong place (at the bottom of the page).

[Wugs (wugs)]

The page layout was imported correctly with LibreOffice 3.4.x, therefore I add the keyword 'regression'.

[Wugs (wugs)]

Bug 47933 - "rtf bug" is very very similar. But I propose to close bug 47933 in favour of this (the present) bug.

[Z-jbf-faure (z-jbf-faure)]

Should be interesting to know how the bugdoc has been created. Indeed the layout simulates a table as in bug 47495 whom bugdoc (attachment 58723) has been created by Oracle Report.

Best regards. JBF

[Wugs (wugs)]

Another similar bug: bug 49403 - "RTF: layout of RTF document broken, regression from LibO 3.4".

(It's hard to say if any of these bugs is a real duplicate; this would need good understanding of the RTF format, and is beyond my horizon. We will know if one of them is fixed: if bug B goes away after fixing bug A, it was a duplicate ...)

[Robinson Tryon (colonelqubit)]

Regression does appear in oldest version of bibisect-3.5.tar.lzma and must be older.

[Wugs (wugs)]

Created attachment 62414
Screenshot of the sample document opened with LibreOffice 3.5.4.2 on MacOS X

To document the current state of affairs, I attach another screenshot, this time taken with LibreOffice 3.5.4.2 (on MacOS X 10.6.8).

It shows that some fixes to other bugs have also improved the look of our sample file a bit, but the layout is still not correct.

[Wugs (wugs)]

Created attachment 69057
Screenshot of the sample document opened with LibreOffice 3.6.3.1 on MacOS X

To document the current state of affairs, I attach another screenshot, this time taken with LibreOffice 3.6.3.1 (on MacOS X 10.6.8).

It shows that some fixes to other bugs have also improved the look of our sample file again, but the layout is still not correct.

[Vmiklos-g (vmiklos-g)]

OK, I think I know what's going on here. The vertical position of some text frames is incorrect, as \pvmrg is the default in RTF, but not in Writer. I'll fix this in a bit.

[Libreoffice-bugs (libreoffice-bugs)]

Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b7bee4ed5722ce59ffd3394a0330d71d69d66b3

fdo#48442 fix default hori/vert frame anchor during RTF import

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

[Vmiklos-g (vmiklos-g)]

Resolved in master, -3-6 review: https://gerrit.libreoffice.org/993

[Libreoffice-bugs (libreoffice-bugs)]

Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-3-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=99324a9dc5b2963be31ebb7a78679c2f3ed3d7a9&g=libreoffice-3-6

fdo#48442 fix default hori/vert frame anchor during RTF import

It will be available in LibreOffice 3.6.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

[Wugs (wugs)]

VERIFIED as FIXED
with LOdev 4.0.0.0.alpha0+ (Build ID: 32315e; pull time: 2012-11-13 00:32:26)
on Mac OS X 10.6.8 (Intel):
The sample file displays correctly (or at least much much better) now.

Thank you, Miklós, very much for this fix (and all the other ones ;-)!

[Wugs (wugs)]

Created attachment 70086
Screenshot: sample document looks fine now, LOdev 2012-11-13

[Björn Michaelsen (bjoern-michaelsen)]

http://anonscm.debian.org/gitweb/?p=pkg-openoffice/libreoffice.git;a=commit;h=865354b68f0922f015ea2f7a5d15954250a45281

[Björn Michaelsen (bjoern-michaelsen)]

lp#1097735: released on Fedora 17 and upstream, patch origin SUSE, fix limited to the RTF file import filter