Exception on non Ubuntu system during sync

Bug #1096556 reported by Heiko Adams
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Lightread
Fix Committed
Medium
Heiko Adams

Bug Description

When running lightread on a system without Unity the following exception is raised during every sync:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/lightread/LightreadWindow.py", line 174, in title_changed
    launcher.set_property("count_visible", False)
NameError: free variable 'launcher' referenced before assignment in enclosing scope

Looks like you've missed to check if 'launcher' is defined before using it.

Revision history for this message
Heiko Adams (heiko-adams-m) wrote :

I've written a patch to fix this problem which I want to contribute

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Hi Heiko, thanks a lot for the patch. However the code is currently hosted at https://github.com/stayradiated/LightRead. Please start a pull request there and we will merge the code after review.

Changed in lightread:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Heiko Adams (heiko-adams-m)
Revision history for this message
Heiko Adams (heiko-adams-m) wrote :

[x] done.

Changed in lightread:
status: Confirmed → Fix Committed
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

We will mark it fix committed once it has been into the main tree. Thanks for your pull request again. If you are comfortable with javascript and css, please help us fix other bugs if you got the time.

Changed in lightread:
status: Fix Committed → In Progress
Revision history for this message
consindo (cooperjona) wrote :

Merged.

Changed in lightread:
status: In Progress → Fix Committed
Revision history for this message
ruiqi (smile-ruiqi) wrote :

I like this app. Thanks!
I change ajax "timeout" in lightread/share/lightread/media/app/scripts/app.js to 50 seconds. I solved this bug.
But I see "timeout: 8000, //Wait 8 secs if connection problem - NZ internet is slow!" in https://github.com/stayradiated/LightRead/blob/master/App/scripts/app.js.
Funny.
I propose to change timeout to 80000. You know, China's network is very very slow! And must use SSH or VPN。

Revision history for this message
Heiko Adams (heiko-adams-m) wrote :

This looks like a problem that has nothing to deal with this issue and schould be moved to a seperate bug.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.