Mouse over waveform should scale with zoom

Bug #1094887 reported by Mel Grubb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Daniel Schürmann

Bug Description

With the waveform zoom at its default setting, the waveform moves correctly under the mouse. When you zoom in to a larger view of the waveform, it still moves as if it were at the default zoom. By that I mean that the track continues to move as far forward or backward as it would if you were at the default zoom level. When you are zoomed in, the waveform moves much faster than your mouse. I think the precision should scale so that at any zoom level, the waveform continues to move 1:1 with the mouse. This would be useful for zooming in to fine-tune beatgrid or loop alignments.

Tags: waveform

Related branches

Changed in mixxx:
status: New → Fix Committed
Revision history for this message
jus (jus) wrote :

Daniel can you link to the branch/revision where the fix was committed, or was the bug's status changed by mistake?

Revision history for this message
jus (jus) wrote :

Agree with Mel here, the mouse sensitivity needs some work.
Requested something similar in https://bugs.launchpad.net/mixxx/+bug/883819, maybe this could be solved together.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you jus for your hint. Confirmed was desired!

Changed in mixxx:
status: Fix Committed → Confirmed
Revision history for this message
Daniel Schürmann (daschuer) wrote :

The attached patch solves the problem against lp:mixxx/1.11 #3667

Changed in mixxx:
status: Confirmed → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Revision history for this message
jus (jus) wrote :

Tested your patch and like the added functionality, thanks.

To me, the scratch is still too sensitive if zoomed out (zoom level 16.7). We had this discussion back then when introducing the waveform scratch, see lp:790744

tags: added: waveform
Changed in mixxx:
importance: Undecided → Wishlist
milestone: none → 1.11.0
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

patch looks good

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Committed to lp:mixxx/1.11 revision 3704.

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Mel Grubb (melgrubb) wrote :

I just ran the latest nightly build, and the mouse/waveform scaling is perfect. Nice job.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6821

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.