handle presets without an <info> section

Bug #1094708 reported by James Mullineaux
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan

Bug Description

Added the touchosc_alpha1.midi.xml file(from: http://www.mixxx.org/forums/viewtopic.php?f=7&t=3313) to Mixxx/Contents/Resources/controllers
and it fails to show up in the preset drop down menu when adding the midi controller in preferences. This does work under 1.9 and 1.10 using the path Mixxx/Contents/Resources/midi

iMac 2.66 Intel Core2 Duo
OS X 10.8.2

Tags: easy weekend

Related branches

Revision history for this message
jus (jus) wrote :

The info section is missing in the linked xml file, see http://mixxx.org/wiki/doku.php/midi_controller_mapping_file_format#file_format
Therefor it is selectable, but shows up as blank line in the drop-down menu. Replace the existing file in the /controllers sub-folder with the attached file and try again, i just added a dummy info section.

Revision history for this message
James Mullineaux (jmxphoto) wrote :

That worked. Thanks!

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks -- we should make a default <info> that is sane (i.e. just make a title based on the filename) for presets that don't have one.

summary: - added midi controller xml file not recognized
+ handle presets without an <info> section
Changed in mixxx:
milestone: none → 1.11.0
importance: Undecided → Medium
status: New → Confirmed
tags: added: easy weekend
Changed in mixxx:
assignee: nobody → CHINMAY GUPTA (chinmaygupta28)
assignee: CHINMAY GUPTA (chinmaygupta28) → nobody
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Confirmed → Fix Committed
assignee: nobody → RJ Ryan (rryan)
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6816

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.