Decompressor contexts incorrectly preserved if MAX_CID is changed

[Didier Barvaux]

When MAX_CID is changed at decompressor (through the rohc_decomp_set_max_cid() function), the array of decompression contexts is either enlarged or reduced. Some existing contexts (minimum of the old and new MAX_CID) can be preserved. The decompressor fails to do it correctly because the memcpy is too short:

  memcpy(new_contexts, decomp->contexts,
                   rohc_min(decomp->medium.max_cid, max_cid) + 1);

The * sizeof(struct d_context *) is missing. Thanks to Yura for finding this problem.

[Didier Barvaux (didier-barvaux)]

Confirmed on main branch.

[Didier Barvaux (didier-barvaux)]

Confirmed on 1.5.x branch.

[Didier Barvaux (didier-barvaux)]

Branch 1.4.x is not affected.

[Didier Barvaux (didier-barvaux)]

Branch 1.3.x is not affected.

[Didier Barvaux (didier-barvaux)]

Fixed in branch 1.5.x. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.5.x/revision/554

[Didier Barvaux (didier-barvaux)]

Fixed on main branch. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/643