Drop THUMB2 config workaround from the build script

Bug #1092832 reported by Milo Casagrande
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro CI
Fix Released
Medium
Milo Casagrande

Bug Description

In the 'jenkins_common_lib' file we have a workaround to for a specific kernel. This should be avoided in the linaro-ci scripts, and handled directly in the kernel config fragments.

The lines are:

# Enabling the THUMB2 kernel option as the THUMB kernel does not seem to work
# well with THUMB2 userspace. This fixes the reboot issue(bug: 860556) we have seen
# for THUMB Kernel working with THUMB2 userspace.

echo "CONFIG_ARCH_OMAP2=n" >> $WORKSPACE/$pkg_dir/.config
echo "CONFIG_THUMB2_KERNEL=y" >> $WORKSPACE/$pkg_dir/.config

Related branches

Revision history for this message
Fathi Boudra (fboudra) wrote :

Andrey, could you ensure this is properly handled at linux-linaro config fragments level?
The proper fix should be there.

Revision history for this message
Andrey Konovalov (andrey-konovalov) wrote :

Fathi,

The linux-linaro-core-tracking and the linux-linaro trees use config fragments from config-*-tracking (equivalent to config-*-3.7 at the moment) branches of kernel/configs.git. There CONFIG_THUMB2_KERNEL=y is already in linaro-base.conf, and no other config fragment redefines this (Tixy has fixed android.conf WRT CONFIG_THUMB2_KERNEL on Nov 5, 2012). CONFIG_ARCH_OMAP2 is applicable to linaro/configs/omap4.conf only, and is disabled there. Adding "# CONFIG_ARCH_OMAP2 is not set" to linaro-base.conf wouldn't break anything, but is overkill, looks ugly, and adds more buzz to logs ("Value requested for CONFIG_ARCH_OMAP2 not in final .config ... Actual value:" for all non-OMAP configs).

The linux-linaro-tracking tree (the v3.4 based one) doesn't use config fragments at all.

So the current linux-linaro config fragments handle this OK already.

Milo Casagrande (milo)
Changed in linaro-ci:
status: New → In Progress
assignee: nobody → Milo Casagrande (milo)
milestone: none → 2013.01
importance: Undecided → Medium
Milo Casagrande (milo)
Changed in linaro-ci:
status: In Progress → Fix Committed
Milo Casagrande (milo)
Changed in linaro-ci:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.