CCSM segfaults if no settings found
Bug #1092651 reported by
Robert M
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
Medium
|
Robert M | ||
0.9.8 |
Won't Fix
|
Undecided
|
Unassigned | ||
compiz (Ubuntu) |
Fix Released
|
Medium
|
Robert M |
Bug Description
I've been trying to get compiz working on Debian, and since I installed from source, no settings were put into GConf. When I tried to start CCSM, it printed out an error that it could not read settings from the backend. It then proceeded to segfault.
Anyway, it turns out that the GConf backend was just not checking for errors, it was assuming that the data was good. Since there were no settings, that was not the case. I've attached a patch to fix this issue.
Just a comment as well: #define TRUE ~0 is very annoying, since that will convert to -1 as a signed integer, which could easily be mistaken for an error condition.
Related branches
lp:~compiz-team/compiz/compiz.fix_1092651
- Daniel van Vugt: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 68 lines (+14/-3)1 file modifiedcompizconfig/integration/gnome/src/ccs_gnome_integration.c (+14/-3)
Changed in compiz (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Robert M (osfan6313) |
Changed in compiz: | |
status: | In Progress → Fix Committed |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Robert.
Thanks for the patch. I've uploaded a new branch and proposed it for merging with your patch included, and some coding style things cleaned up. I also removed the check for mouseButtonModifier = 0 - as that is a non-error case.
It passes tests, but I do not have the time to manual-test it. Can you check if it remains true to your original patch?