Glance

Supplied image size should be verified against actual size

Bug #1092584 reported by Eoghan Glynn on 2012-12-20

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Glance	Fix Released	Medium	Eoghan Glynn	Glance grizzly-2 "g2"
Folsom	Fix Released	Medium	Eoghan Glynn	Glance 2012.2.3
Grizzly	Fix Released	Medium	Eoghan Glynn	Glance 2013.1 "grizzly"

Bug Description

Currently a supplied checksum is verified against the actual checksum calculated by the backend store, and the image is killed on mismatch.

However we do not similarly verify the supplied image size, if provided.

Eoghan Glynn (eglynn) on 2012-12-20

Changed in glance:
milestone:	none → grizzly-2
status:	New → In Progress
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-12-20: Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18485

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-01-02: Fix merged to glance (master)

Reviewed: https://review.openstack.org/18485
Committed: http://github.com/openstack/glance/commit/f958b1eeaa58f0c4090185348d70632f81902e9c
Submitter: Jenkins
Branch: master

commit f958b1eeaa58f0c4090185348d70632f81902e9c
Author: Eoghan Glynn <email address hidden>
Date: Thu Dec 20 15:33:56 2012 +0000

Verify size in addition to checksum of uploaded image

Fixes bug 1092584

    Previously only the supplied checksum was verified against the actual
    checksum calculated by the backend store, with the image being killed
    on mismatch.

Now we also similarly verify the supplied image size, if provided.

Change-Id: I87fa3ff77715111f1095f3ebe64cd699776ec27e

Changed in glance:
status:	In Progress → Fix Committed

Eoghan Glynn (eglynn) on 2013-01-03

tags:

added: folsom-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-01-03: Fix proposed to glance (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/18873

Thierry Carrez (ttx) on 2013-01-09

Changed in glance:
status:	Fix Committed → Fix Released

Brian Waldon (bcwaldon) on 2013-01-09

Changed in glance:
assignee:	nobody → Eoghan Glynn (eglynn)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-01-10: Fix merged to glance (stable/folsom)

Reviewed: https://review.openstack.org/18873
Committed: http://github.com/openstack/glance/commit/5e5e722d353e0670d2aa06cbac8e138617c10806
Submitter: Jenkins
Branch: stable/folsom

commit 5e5e722d353e0670d2aa06cbac8e138617c10806
Author: Eoghan Glynn <email address hidden>
Date: Thu Dec 20 15:33:56 2012 +0000

Verify size in addition to checksum of uploaded image

Fixes bug 1092584

    Previously only the supplied checksum was verified against the actual
    checksum calculated by the backend store, with the image being killed
    on mismatch.

Now we also similarly verify the supplied image size, if provided.

Change-Id: I87fa3ff77715111f1095f3ebe64cd699776ec27e

tags:

added: in-stable-folsom

Mark McLoughlin (markmc) on 2013-01-22

tags:

removed: folsom-backport-potential in-stable-folsom

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.