TPAC: Account summary / eliminate text crowding

Bug #1092286 reported by Dan Pearl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

EG <= 2.3
PG/Opensrf: Don't care
Linux: Don't care
Browser: Don't care

In the small table in the Account Summary screen, the row contents can directly abut the "View All". This is simply unattractive.

Tags: pullrequest
Revision history for this message
Dan Pearl (dpearl) wrote :
tags: added: pullrequest
Changed in evergreen:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Pasi Kallinen (paxed) wrote :

That does fix the problem, but I'm boggling at the code - I think it would make more sense to put all that information into a single html table instead of using separate tables (wrapped in divs!) for each row.

Here's my suggested fix:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/acct_sum_table

Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
Revision history for this message
Remington Steed (rjs7) wrote :

After inquiring about the history of the "separate tables wrapped in divs" code, I believe it is safe to change the structure of the layout for the Account Summary table. Thanks Dan Pearl for raising this issue and providing the first fix. Thanks Pasi for improving on it. I added one commit with minor changes which restores the original look of the table and fixes some whitespace in the table code. Rebased to master, pushed here:

working/user/rsteed/acct_summary_padding
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/acct_summary_padding

Revision history for this message
Dan Scott (denials) wrote :

Thanks everyone. Remington, rather than having a separate whitespace fix on top of Pasi's commit, I just merged that particular whitespace change into Pasi's commit, then committed your CSS tweak on its own. Hope you don't mind!

BTW, given the inline CSS specifying width:662px and the like that remain in this file, there's still a _lot_ of work to do... but you guys have done a good job of improving things! Thanks.

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.