upower fails to recognize hid devices with new kernels

Bug #1091702 reported by Peter Hurley
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
upower (Ubuntu)
Fix Released
Low
Unassigned
Precise
Won't Fix
Low
Unassigned

Bug Description

In newer kernels, hiddev* devices now have class "usbmisc", rather than "usb" (for reference see http://www.spinics.net/lists/linux-usb/msg62276.html ).

Attached is a patch that fixes this without changing existing behavior for older kernels. The patch commit message contains an example attribute-walk on 3.7.0

SRU INFORMATION:
Patch: http://cgit.freedesktop.org/upower/commit/?id=9f31068707fc79744961cea7258b0eb262effbf1, in raring
Impact: We regularly backport newer kernels to LTS releases, and we do not want to cause regressions in power management, especially not if we switch some 12.04.x point release to a newer kernel by default.
Regression potential: None, it keeps recognizing the "usb" subsystem, and "usbmisc" does not yet exist in Precise final.
Test case: This needs a device like an USB controlled UPS or a wireless mouse/keyboard which reports its battery charge. These should work as before with the updated upower, and continue to report their charge in the power indicator with newer kernels.

Tags: patch
Revision history for this message
Peter Hurley (phurley) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "[PATCH] Fix device matching for recent kernels" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Peter Hurley (phurley) wrote :

This patch supersedes earlier patch.

summary: - udev rules fail to match hid devices with new kernels
+ upower fails to recognize hid devices with new kernels
Revision history for this message
Peter Hurley (phurley) wrote :

Upstreamed.

On Sat, 2012-12-29 at 13:11 +0000, Richard Hughes wrote:
On 26 December 2012 18:51, Peter Hurley <email address hidden> wrote:
> > In recent kernels, hiddev* devices now have class "usbmisc", rather
> > than "usb" (see http://www.spinics.net/lists/linux-usb/msg62276.html).
> > This change translates into a change in SUBSYSTEM matching for hiddev*
> > devices. This fix addresses this for recent kernels while retaining
> > existing behavior. For reference, here is an attribute-walk for a
> > CyberPower CPS 1500C on kernel 3.7.0:
>
> Applied to master, thanks!
>
> Richard.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Peter, that fix [1] is in 0.9.19 which just got released and uploaded to the current Ubuntu serie

[1] http://cgit.freedesktop.org/upower/commit/?id=9f31068707fc79744961cea7258b0eb262effbf1

Closing the bug, not sure if we should backport to older series to support running newer kernels on those for hardware support

Changed in upower (Ubuntu):
importance: Undecided → Low
status: New → Fix Released
Changed in upower (Ubuntu Precise):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

I uploaded an SRU update for precise to the review queue.

description: updated
Changed in upower (Ubuntu Precise):
status: Triaged → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote :

The Precise Pangolin has reached end of life, so this bug will not be fixed for that release

Changed in upower (Ubuntu Precise):
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.