Useless duplicates origin when merging purchase orders
Bug #1091268 reported by
Yann Papouin
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Committed
|
Low
|
OpenERP R&D Addons Team 2 | |||
| OpenERP Community Backports (Addons) | Status tracked in 7.0 | |||||
| 6.1 |
Fix Released
|
Low
|
Yann Papouin | |||
| 7.0 |
Fix Released
|
Low
|
Yann Papouin | |||
Bug Description
When merging multiple purchase orders from wizard, origin field is concatenated even if the origin is the same:
eg: :MO/00005 :MO/00005 :MO/00005 :MO/00005 :MO/00003 :MO/00003 :MO/00003
It should be avoided, at least because the origin field is limited to 64 chars. I'm attaching a patch to fix this
if porder.origin and not porder.origin in order_infos[
order_
Related branches
lp:~openerp-dev/openobject-addons/trunk-bug-1091268-api
- Yannick Vaucher @ Camptocamp (community): Needs Fixing
- OpenERP Core Team: Pending requested
-
Diff: 14 lines (+2/-2)1 file modifiedpurchase/purchase.py (+2/-2)
lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates
- Yannick Vaucher @ Camptocamp: Approve (code review, no tests)
- Holger Brunn (Therp): Approve (code review)
- Pedro Manuel Baeza: Approve (code review)
-
Diff: 13 lines (+2/-1)1 file modifiedpurchase/purchase.py (+2/-1)
lp:~yann-papouin/openobject-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates
- Yannick Vaucher @ Camptocamp (community): Needs Fixing
- OpenERP Core Team: Pending requested
-
Diff: 13 lines (+2/-1)1 file modifiedpurchase/purchase.py (+2/-1)
lp:~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates
- Pedro Manuel Baeza: Approve (code review)
- Sandy Carter (http://www.savoirfairelinux.com): Approve (code review, pep8)
- Holger Brunn (Therp): Approve (code review)
-
Diff: 13 lines (+2/-1)1 file modifiedpurchase/purchase.py (+2/-1)
Revision history for this message
| Yann Papouin (yann-papouin) wrote | #1 |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2) |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
| Changed in openobject-addons: | |
| status: | In Progress → Confirmed |
| Changed in openobject-addons: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Yann Papouin (yann-papouin) wrote | #2 |
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | #4 |
To post a comment you must log in.
Personally I will keep my patch, as the split function will duplicates origins when there is spaces inside initial sentence:
eg:
- originA = "Prod: 12345"
- originB = "Prod: 12345"
will create :
- origin = "Prod: 12345 Prod: 12345"