buildcosts and "wares that get recycled" preview moves the window
Bug #1090887 reported by
Nasenbaer
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
High
|
Gabriel Margiani | ||
Bug Description
If you want to dismantle a building, you click on the building and than click on the dismantle button in the building window. But due to the new feature of showing the wares that will be recycled through the dismantling of the building, the window will move, if it is close to the main windows bottom. Similar problems appear in the construct building window.
This leads to false clicks and can be very disturbing.
I suggest to take care about the needed space in the initial window and thus avoid the resizing. in case of the building window the space and thus the resources recycled could be shown above the buttons, in case of the construct building window, the list of wares could stay were it is, but the space could be initialized as well.
Related branches
lp:~gamag/widelands/buildcostTooltip
- SirVer: Needs Information
- Gabriel Margiani: Needs Resubmitting
-
Diff: 1046 lines (+155/-309)8 files modifiedsrc/logic/item_ware_descr.h (+1/-0)
src/ui_basic/icongrid.cc (+17/-26)
src/ui_basic/icongrid.h (+1/-2)
src/wui/buildingwindow.cc (+25/-73)
src/wui/buildingwindow.h (+0/-5)
src/wui/fieldaction.cc (+63/-75)
src/wui/waresdisplay.cc (+27/-85)
src/wui/waresdisplay.h (+21/-43)
Revision history for this message
| Shevonar (shevonar) wrote | #1 |
Revision history for this message
| Shevonar (shevonar) wrote | #2 |
| summary: |
- New "show wares that are recycled" feature moves window + buildcosts and "wares that get recycled" preview moves the window |
| Changed in widelands: | |
| assignee: | nobody → Gabriel Margiani (gamag) |
Revision history for this message
| SirVer (sirver) wrote | #3 |
| Changed in widelands: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| SirVer (sirver) wrote | #4 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It is not a duplicate of bug #1019585 but the problem described here is also mentioned there in the comments. If this bug gets fixed in the suggested way #1019575 can also be closed.