GUI should protect GUI charm
Bug #1090716 reported by
Gary Poster
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-gui |
Fix Released
|
High
|
Benji York | ||
Bug Description
If a GUI charm is providing the GUI interface, unexposing or deleting the charm will cause the GUI to immediately stop working.
We discussed a number of approaches to addressing this, ranging from doing nothing, through providing custom warnings, to hiding the GUI charm in the GUI.
The (eventual) consensus solution is to disable the destroy and unexpose
functions and provide a warning on the settings page.
Related branches
lp:~gary/juju-gui/bug1090716
- Juju GUI Hackers: Pending requested
-
Diff: 394 lines (+286/-15)5 files modifiedapp/views/topology/relation.js (+10/-0)
app/views/topology/service.js (+23/-14)
app/views/utils.js (+79/-1)
test/test_environment_view.js (+70/-0)
test/test_utils.js (+104/-0)
lp:~benji/juju-gui/no-foot-shooting
- Juju GUI Hackers: Pending requested
-
Diff: 1140 lines (+684/-172)15 files modifiedapp/templates/overview.handlebars (+1/-1)
app/templates/service-config.handlebars (+12/-6)
app/templates/service-footer-common-controls.partial (+30/-27)
app/templates/service-footer-destroy-service.partial (+7/-8)
app/templates/service.handlebars (+7/-8)
app/views/service.js (+142/-100)
app/views/topology/service.js (+24/-9)
app/views/utils.js (+62/-0)
lib/views/stylesheet.less (+16/-7)
test/index.html (+1/-0)
test/test_application_notifications.js (+2/-0)
test/test_service_view.js (+113/-2)
test/test_templates.js (+128/-0)
test/test_topology.js (+72/-4)
test/test_utils.js (+67/-0)
| description: | updated |
| summary: |
- GUI should hide GUI charm + GUI should protect GUI charm |
| description: | updated |
| Changed in juju-gui: | |
| assignee: | nobody → Benji York (benji) |
| milestone: | none → 0.1.4+build.311 |
| status: | Triaged → In Progress |
| Changed in juju-gui: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
