Missing/Hidden Tracks should have buttons to restore/delete/relocate like AutoDJ

[Max Linke]

I thought it would be nive to have buttons for this like the 'Shuffle'/'Fade Now' buttons in the AutoDJ view instead of just having some other options in the context menu. I can imagine that some people will be lost in the begining how they can unhide a track or relocate it.

[Max Linke (max-linke)]

Here is a patch for this. I've also removed some code from libraryView which is not used anymore.

[Daniel Schürmann (daschuer)]

Patch looks good to me. Tank you.

I wonder why we should bring this patch with the dedicated bugfix release 1.11.1.
For me, this is a language and manual dependent feature for a .0 release. So we should add it to Milestone 1.11 or 1.12.

For me it is fine for 1.11.

One minor point: It would be nice to gayout the buttons if the list is empty.

[Daniel Schürmann (daschuer)]

oops: .. gray out ...

[RJ Skerry-Ryan (rryan)]

Fine w/ me for 1.11.0.

I'm just hopping on a plane so I didnt' get to look at this too closely. It looks like the patch re-enables search for AutoDJ. We disabled it because the auto-dj logic uses the current view to determine the next track so a search would affect what auto-dj plays next. Unless this also fixes that then I think search needs to stay disabled.

[Daniel Schürmann (daschuer)]

Just noticed a segfault in src/library/mixxxlibraryfeature.cpp:110 after applying the patch.

[Max Linke (max-linke)]

@rryan yup I accidently activated search for AutoDJ

@Daniel, the new version grays out the buttons if the list gets empty.

Mixxx segfaults when it tries to call the destructor of DlgMissing. Everything works if I don't delete DlgMissing/DlgHidden explicitly in MixxxLibraryFeature. The same error can be observed when DlgAutoDJ is explicitly deleted in AutoDJFeature.
I think this is because they are parented to WLibrary which gets deleted later.

The last thing that bugs me is that the buttons will go into a pressed state when they are pressed instead of just staying in the unpressed state as they do in the AutoDJ view

[Daniel Schürmann (daschuer)]

Hi Max, thank you for the update.
The new patch does not cleanly perform against lp:mixxx/1.11 so I cannot test.

I think the button issue might be solved by
+ <property name="checkable">
+ <bool>false</bool>
+ </property>

As far as i can see, the patch logs good apart from that.

[Daniel Schürmann (daschuer)]

Agrrr .. my fault, patch performs well, sorry.

[jus (jus)]

Work as expected here,thanks.
Some minor things:
* In other single button views (Recordings), we have buttons aligned from the right to left side. It is reversed here.
* Add a hint to the tooltips, that you first have to select a track before you'll be able to perform an action.
  Purge Buttons:
  "Purge selected tracks from the library."
  Unhide button:
  "Unhide selected tracks from the library."

For a moment a thought about additional "Select all" and "Rescan Library" buttons in there, but now i'm not completely sure if they are useful. Opinions?

[Max Linke (max-linke)]

A "Select all" button would be useful. I don't think the 'rescan library'-button is required.

[Max Linke (max-linke)]

Buttons are on the right now. Added a "Select All"-button and correted the tool tips

[Daniel Schürmann (daschuer)]

Patch looks good, please commit.

If you want to go an extra mile, you could gray out the select all button if no track is in table (like currently the other buttons) and gray out the other buttons if no track is selected.

[Max Linke (max-linke)]

I changed it now so that the unhide/purge buttons are only enabled if there are some tracks selected. The "select all" button is a bit more complicated as it should also change depending on the search results. So right now it is enabled all the time like in dlgprepare.* for consistency.

To also disable it depending on how many songs are shown I will have to find a way to get the number of displayed tracks after a search.

could you please look over this patch aswell. I only changed dlghidden.h/cpp dlgmissing.h/cpp

[Daniel Schürmann (daschuer)]

Thank you Max, it looks good to me!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6778