Java fails to read numeric opensrf config values

[Bill Erickson]

Recent changes to the Java JSON library are causing problems with the OpenSRF Java configuration file parsing.

See working => user/berick/java-config-parse-repairs

From the commit:
=====

Java config parsing, in particular getString and getInt, no longer fail when encountering a number value in the internl JSON->Map object.

Java does not allow the following cast:

String s = (String) someNumber;

Instead, rely on the object's toString() which is safe and guaranteed to exist.
====

[Jason Stephenson (jstephenson)]

Yeah, I have that commit, too, and still Java doesn't work for me.

[Jason Stephenson (jstephenson)]

Here's what I get:

{"config":{"shared":{"log_protect":{"match_string":["open-ils.auth.authenticate.verify","open-ils.auth.authenticate.complete","open-ils.auth_proxy.login","open-ils.actor.user.password","open-ils.actor.user.username","open-ils.actor.user.email","open-ils.actor.patron.update","open-ils.cstore.direct.actor.user.create","open-ils.cstore.direct.actor.user.update","open-ils.cstore.direct.actor.user.delete"]}},"opensrf":{"port":5222,"passwd":"PASSWD","loglevel":3,"username":"opensrf","domain":"private.localhost","routers":{"router":[{"services":{"service":["opensrf.math","open-ils.actor","open-ils.acq","open-ils.auth","open-ils.auth_proxy","open-ils.booking","open-ils.cat","open-ils.circ","open-ils.collections","open-ils.fielder","open-ils.pcrud","open-ils.permacrud","open-ils.reporter","open-ils.resolver","open-ils.search","open-ils.supercat","open-ils.vandelay","open-ils.serial"]},"name":"router","domain":"public.localhost"},{"name":"router","domain":"private.localhost"}]},"settings_config":"/openils/conf/opensrf.xml","logfile":"/openils/var/log/osrfsys.log","router_name":"router"},"gateway":{"port":5222,"passwd":"PASSWD","loglevel":3,"username":"opensrf","services":{"service":["opensrf.math","opensrf.dbmath","open-ils.cat","open-ils.search","open-ils.circ","open-ils.actor","open-ils.auth","open-ils.auth_proxy","open-ils.collections","open-ils.reporter"]},"client":true,"domain":"public.localhost","logfile":"/openils/var/log/gateway.log","router_name":"router"},"routers":{"router":[{"loglevel":2,"transport":{"unixpath":"/openils/var/sock/unix_sock","port":5222,"username":"router","resource":"router","max_reconnect_attempts":5,"server":"public.localhost","connect_timeout":10,"password":"PASSWD"},"trusted_domains":{"client":["private.localhost","public.localhost"],"server":"private.localhost"},"logfile":"/openils/var/log/router-public.log"},{"loglevel":2,"transport":{"port":5222,"username":"router","resource":"router","max_reconnect_attempts":5,"server":"private.localhost","connect_timeout":10,"password":"PASSWD"},"trusted_domains":{"client":"private.localhost","server":"private.localhost"},"logfile":"/openils/var/log/router-private.log"}]}}}
org.opensrf.MethodException: java.lang.NullPointerException
 at org.opensrf.ClientSession.atomicRequest(ClientSession.java:171)
 at org.open_ils.util.Utils.login(Utils.java:30)
 at Login.main(Login.java:29)
Caused by: java.lang.NullPointerException
 at org.opensrf.Session.send(Session.java:55)
 at org.opensrf.Request.send(Request.java:62)
 at org.opensrf.ClientSession.request(ClientSession.java:107)
 at org.opensrf.ClientSession.request(ClientSession.java:89)
 at org.opensrf.ClientSession.atomicRequest(ClientSession.java:164)
 ... 2 more

I've obfuscated the password in the error above, of course. Similar Perl code works just fine.

[Jason Stephenson (jstephenson)]

Here's what I'm using to test.

Let me know if there's anything wrong with my Java code.

[Bill Erickson (berick)]

Thanks Jason. The test file is failing because it's not connecting to the opensrf network (Sys.bootstrapClient). I suggest trying the test code in the repository.

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/java/org/open_ils/test/TestLogin.java

% CLASSPATH=$STUFF java org.open_ils.test.TestLogin /openils/conf/opensrf_core.xml admin PASSWORD

[Jason Stephenson (jstephenson)]

Thanks!

It's working for me, now.

[Jason Stephenson (jstephenson)]

Pushed a signoff to

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/dyrcona/java-config-parse-repairs

I would have pushed to the main repository, but I don't actually have that configured as a remote, and I'm feeling a little lazy. :)

[Dan Scott (denials)]

Committed to master and rel_2_1. Thanks to both of you!