Staff client offline mode error message

Bug #1089657 reported by Anoop Atre
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.3
Fix Released
Undecided
Unassigned

Bug Description

Evergreen Versions: 2.3.1

There is a new feature in the 2.3.1 staff client which generates line numbers. This is broken in offline mode and instead we get a message "function (my, scratch) { return"_";}" [screenshot attached]. It seems to be a cosmetic bug and does not affect data integrity.

Revision history for this message
Anoop Atre (anoop-atre) wrote :
Revision history for this message
Ben Shum (bshum) wrote :

Confirmed.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.3.2
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.3.2 → 2.3.3
Changed in evergreen:
milestone: 2.3.3 → 2.4.0-alpha
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Galen Charlton (gmc)
tags: added: bitesize
Revision history for this message
Dmitry Nechai (nechai-dmitry) wrote :

In list.js at start you create obj.columns for lineno, but later you don`t process this value so it`s return default render function,

Changed in evergreen:
status: Confirmed → In Progress
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Dmitry,

Thanks for the patch. I've spent several hours looking at and testing it this morning and it works for me! I did make 1 small change before committing the code. I change the initial value for this.count_for_display from 0 to 1 so that the display would be more consistent with other list interfaces in the staff client. (The offline transaction management interface for instance starts list number for display at 1.)

If you do get accepted as a GSOC student, or if you'd like to make future contributions to Evergreen, please send a public ssh key to the git admins (<email address hidden>). See http://www.evergreen-ils.org/dokuwiki/doku.php?id=dev:git for more information.

The patch has been pushed to master and rel_2_3 for great justice!

Thanks,
Jason Stephenson

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
status: In Progress → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.