cfn-signal waitcondition fails due to URL quoting

[Steve Baker]

waitcondition calls from the instance are failing for me. By the time cfn-signal calls curl, the URL is no longer quoted. This means everything after the first & is ignored, which is why the ec2 signature is not found.

The instance calls:
[root@teststack bin]# /opt/aws/bin/cfn-signal -e 0 -r "Wiki server setup complete" 'http://192.168.1.10:8000/v1/waitcondition/c10663eb-7479-4e0a-8c4d-5fae9e0259a6/resources/WaitHandle?Timestamp=2012-12-11T01%3A06%3A53Z&SignatureMethod=HmacSHA256&AWSAccessKeyId=2a4fb20fce204672b9e1061851ff3e8f&SignatureVersion=2&Signature=Pf3Z8gBgmwtiisDnrUWIm8tQZRmHkzdPyNibfGqSNKw%3D'
DEBUG [2012-12-10 21:02:46,374] cfn-signal called Namespace(data='Application has completed configuration.', exit_code='0', reason='Wiki server setup complete', success='true', unique_id='00000', url='http://192.168.1.10:8000/v1/waitcondition/c10663eb-7479-4e0a-8c4d-5fae9e0259a6/resources/WaitHandle?Timestamp=2012-12-11T01%3A06%3A53Z&SignatureMethod=HmacSHA256&AWSAccessKeyId=2a4fb20fce204672b9e1061851ff3e8f&SignatureVersion=2&Signature=Pf3Z8gBgmwtiisDnrUWIm8tQZRmHkzdPyNibfGqSNKw%3D')
DEBUG [2012-12-10 21:02:46,375] Running command: curl -X PUT -H 'Content-Type:' --data-binary '{"Status": "SUCCESS", "Reason": "Wiki server setup complete", "Data": "Application has completed configuration.", "UniqueId": "00000"}' http://192.168.1.10:8000/v1/waitcondition/c10663eb-7479-4e0a-8c4d-5fae9e0259a6/resources/WaitHandle?Timestamp=2012-12-11T01%3A06%3A53Z&SignatureMethod=HmacSHA256&AWSAccessKeyId=2a4fb20fce204672b9e1061851ff3e8f&SignatureVersion=2&Signature=Pf3Z8gBgmwtiisDnrUWIm8tQZRmHkzdPyNibfGqSNKw%3D

heat-api-cfn logs:
2012-12-11 15:02:48 DEBUG [heat.api.middleware.version_negotiation] Processing request: PUT /v1/waitcondition/c10663eb-7479-4e0a-8c4d-5fae9e0259a6/resources/WaitHandle Accept: */*
2012-12-11 15:02:48 DEBUG [heat.api.middleware.version_negotiation] Matched versioned URI. Version: 1.0
2012-12-11 15:02:48 INFO [heat.api.aws.ec2token] Checking AWS credentials..
2012-12-11 15:02:48 INFO [heat.api.aws.ec2token] No AWS Signature found.
2012-12-11 15:02:48 DEBUG [root] XML response : <ErrorResponse><Error><Message>The request signature does not conform to AWS standards</Message><Code>IncompleteSignature</Code><Type>Sender</Type></Error></ErrorResponse>
2012-12-11 15:02:48 DEBUG [eventlet.wsgi.server] 10.0.0.2 - - [11/Dec/2012 15:02:48] "PUT /v1/waitcondition/c10663eb-7479-4e0a-8c4d-5fae9e0259a6/resources/WaitHandle?Timestamp=2012-12-11T01%3A06%3A53Z HTTP/1.1" 400 311 0.003889

[Steve Baker (steve-stevebaker)]

Ah, already fixed https://github.com/heat-api/heat-jeos/commit/305f6753abdc9459305cc9c8d21cc17d2d39778b