Mixxx

Add a loop_exit control.

Bug #1088256 reported by RJ Skerry-Ryan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Owen Williams
Mixxx 1.11.0

Bug Description

Forked from Bug #1088117.

We only have reloop_toggle for exiting loops. Technically you can set loop_start/end_position to -1 to clear a loop but we ought to have a button to do it.

Related branches

lp:mixxx/1.11
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

See src/engine/loopingcontrol.cpp to and look at reloop_exit to see how to do it.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
tags: added: easy starter weekend
Revision history for this message
Owen Williams (ywwg) wrote :

Patch attached, with test! Also fixes https://bugs.launchpad.net/mixxx/+bug/1088117

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Patch LGTM!

Changed in mixxx:
milestone: none → 1.11.0
assignee: nobody → Owen Williams (ywwg)
Revision history for this message
Owen Williams (ywwg) wrote :

Committed (r3598)

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6763

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.