makefile and tests are not run automatically before landing
Bug #1087110 reported by
Gary Poster
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-gui |
Fix Released
|
High
|
Unassigned |
Bug Description
Our automated tests are not run automatically. Our makefiles are not run from a pristine state automatically. This is error-prone and has, unsurprisingly, bitten us more than once.
We should make our tests run automatically. lbox has a test hook which is not perfect for this purpose but would be an improvement, if it ran make clean (or at least some version of "make clean" that removed everything except for the downloaded bits like the node_modules), make, and then a test that actually verified the results before submitting the branch.
To post a comment you must log in.
I believe this is no longer the case after the recent PhantomJS branch, at least the tests portion. Anyone able to confirm?