[MIR] gdisk

[James Page]

[Availability]
gdisk in Universe. Builds OK on all supported architectures.

[Rationale]
The latest versions of ceph have good upstart integration; this relies on some new tools for preparing and activating block devices for use by ceph daemons; the tools make extensive use of gdisk to create and manipulate the disks in a GPT format.

[Security]
No security issues found.

[QA]
Package is well maintained in Debian (http://packages.qa.debian.org/g/gdisk.html)
Test script in source package, executed during package build.
Bugs look OK - some outstanding but nothing high/critical.

[Dependencies]
All in main.

[Standards compliance]
OK

[Maintenance]
Well maintained in Debian so should not be to much overhead

[Background information]
gdisk provides a GPT compatibility replacement for fdisk

[Michael Terry (mterry)]

Thanks for patching it to use the upstream test suite! I forwarded your test patch on to Debian (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695173) but realized that the test script upstream uses always returns 0.

So I'd need to see a further patch that fails the build on test failure.

[James Page (james-page)]

Michael

The majority of tests call the verify_part function which verifies that the disk has the correct partition layout etc.. If it does not it will `exit 1` and fail the test script.

The only test I can see which does not exit 1 on failure is change_disk_uid (I can patch that up easily enough); the other exception is the eof_stdin test will just never return if it fails and the build would time out in the end.

[James Page (james-page)]

I've uploaded an updated version of gdisk to Ubuntu and added a revised debdiff including the patch for gdisk_test.sh to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695173

[Michael Terry (mterry)]

Ah, you are right. Sorry. Will review again.

[Michael Terry (mterry)]

Looks OK to me. Would be nice to see a bug subscriber though. Thanks, James!

[Adam Conrad (adconrad)]

Override component to main
gdisk 0.8.5-1ubuntu2 in raring: universe/admin -> main
gdisk 0.8.5-1ubuntu2 in raring amd64: universe/admin/extra -> main
gdisk 0.8.5-1ubuntu2 in raring armhf: universe/admin/extra -> main
gdisk 0.8.5-1ubuntu2 in raring i386: universe/admin/extra -> main
gdisk 0.8.5-1ubuntu2 in raring powerpc: universe/admin/extra -> main
Override [y|N]? y
5 publications overridden.