XTRABACKUP_PID in wsrep_sst_xtrabackup script does nothing

[Raghavendra D Prabhu]

XTRABACKUP_PID in https://bazaar.launchpad.net/~percona-dev/percona-xtradb-cluster/5.5.28/view/head:/Percona-Server/scripts/wsrep_sst_xtrabackup.sh does nothing since Xtrabackup doesn't use that nor does innobackupex.

It needs to be removed as it serves no purpose and also cause
mktemp related bugs like lp:1080829

[Raghavendra D Prabhu (raghavendra-prabhu)]

Reported lp:1086286 to help in the other part of the bug fix (ie. to check if innobackupex is still running and kill it if so).

[Vadim Tkachenko (vadim-tk)]

Original wsrep_xtrabackup_sst had a cleanup procedure, see e.g.
http://bazaar.launchpad.net/~percona-core/percona-xtradb-cluster/5.5.27/view/head:/Percona-Server/scripts/wsrep_sst_xtrabackup.sh

kill_xtrabackup()
{
#set -x
    local PID=$(cat $XTRABACKUP_PID)
    [ -n "$PID" -a "0" != "$PID" ] && kill $PID && (kill $PID && kill -9 $PID) || :
    rm -f "$XTRABACKUP_PID"
#set +x
}

New script from codership-mysql does not have it.

However I believe that cleanup procedure is needed, to exit gracefully if calling binary dies.

[Alex Yurchenko (ayurchen)]

this ticket is invalid, see lp:1080829

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-1267