Mixxx

EngineBuffer code clean up

Bug #1085224 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann
Mixxx 1.11.0

Bug Description

Attached you find a patch which removes some unnecessary code from EngineBuffer and prefixes all member variables with m_

Related branches

lp:mixxx/1.11
Revision history for this message
Daniel Schürmann (daschuer) wrote :
Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
status: New → In Progress
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks.. some long-needed cleanups. The patch looks good:

* It adds ControlObjectThreadMain header and fwd declaration back in -- can remove those.
* Some controls are no longer deleted in the destructor (visual bpm, visual playposition, slip enabled, slip position, etc.).

This is going to cause pretty much every line of the engine-control-refactor branch to conflict though :(.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

(every line in EngineBuffer)

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Commited to lp:mixxx/1.11 revision 3539

Changed in mixxx:
status: In Progress → Fix Committed
milestone: none → 1.11.0
importance: Undecided → Low
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6730

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.