A non-public project can currently be the target of a question.
Bug #1085102 reported by
Richard Harding
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
non-public projects cannot have any questions, however the questions code does not validate that the target isn't a non-public project. It needs to prevent during submission and during retargeting via the ajax code.
Related branches
lp:~jcsackett/launchpad/no-questions-on-disabled-2
- Curtis Hovey (community): Approve (code)
-
Diff: 224 lines (+75/-10)7 files modifiedlib/lp/answers/browser/question.py (+10/-3)
lib/lp/answers/configure.zcml (+11/-0)
lib/lp/answers/stories/project-add-question.txt (+2/-2)
lib/lp/answers/tests/test_vocabulary.py (+25/-2)
lib/lp/answers/vocabulary.py (+19/-1)
lib/lp/app/widgets/launchpadtarget.py (+4/-1)
lib/lp/testing/factory.py (+4/-1)
lp:~jcsackett/launchpad/no-questions-on-disabled
- Curtis Hovey (community): Approve (code)
-
Diff: 108 lines (+44/-1)3 files modifiedlib/lp/answers/browser/question.py (+13/-1)
lib/lp/answers/browser/tests/test_question.py (+18/-0)
lib/lp/answers/templates/question-add-search.pt (+13/-0)
Revision history for this message
| Deryck Hodge (deryck) wrote | #1 |
| Changed in launchpad: | |
| importance: | Critical → High |
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| j.c.sackett (jcsackett) wrote | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
While we're agreeing to fix this before we finish private projects, it's not critical according to our bug triage policy for Launchpad itself.