Allow None for ticks_between_runs when configuring periodic tasks

Bug #1084232 reported by Davanum Srinivas (DIMS)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Davanum Srinivas (DIMS)

Bug Description

This bug was noticed when we set image_cache_manager_interval=0 as default. a review of the code shows that setting ticks_between_runs to 0 will end up executing the periodic_task for every tick. We need to allow setting image_cache_manager_interval to None (or -1?) so that nova/manager.py can entirely skip adding this task to its list of tasks to run.

Changed in nova:
assignee: nobody → Davanum Srinivas (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17076

Changed in nova:
status: New → In Progress
Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/17076
Committed: http://github.com/openstack/nova/commit/27868ddf260286d86c8e048934ffc7573d729702
Submitter: Jenkins
Branch: master

commit 27868ddf260286d86c8e048934ffc7573d729702
Author: Davanum Srinivas <email address hidden>
Date: Wed Nov 28 15:35:30 2012 -0500

    Don't run the periodic task if ticks_between_runs is below zero

    if the user sets say image_cache_manager_interval=-1, then
    don't add the task to the list of periodic tasks

    remove extra braces that i had added

    DocImpact

    Fixes LP #1084232

    Change-Id: Ieecd67ddbc70b815a88f40e72ca2899787d75988

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.