[Trunk]Infinite refund allowed

[Kyle Waid]

Create sale order
Confirm Invoice
Pay Invoice

Go to accounting - customer invoice
Click Refund. Generate Draft refund
Confirm refund invoice, pay invoice

It is now refunded. A further refund should not be possible.
Current functionality allows the user to continuously refund an invoice as many times as they wany. This should not be possible

There also needs to be an indicator status on the original invoice in both list and tree view that clearly shows the customers invoice was refunded.

[Cristian Salamea (ovnicraft)]

Please Amit, point to what series affect, i tested in 6.1 and i can confirm that.

Regards,

[Amit Parik (amit-parik)]

I have confirmed it for trunk, for 6.1 you have to file OPW.

Thanks!

[Kyle Waid (midwest)]

I am really happy to see my bugs being confirmed!

+ 10 !

[Amit Parik (amit-parik)]

Thanks a lot kyle..:)

[Khushboo Bhatt(openerp) (kbh-openerp)]

Hello Kyle,

Your first issue of infinite refund has been fixed on lp:~openerp-dev/openobject-addons/trunk-bug-1083276-kbh branch with following rev no and rev ID and for second point please report a new bug as it is suggestion.

Rev No : 8375
Revision ID: <email address hidden>

Thanks,
Khushboo.

[Kyle Waid (midwest)]

Thank you for the patch, however I do not necessarily agree with the patch. You put a new flag, refund invoice. When a refund is created the flag is true. Then you hide the button refund if refund invoice=true. What about a case where a partial refund is performed, then later a refund for the remainder is granted? I think the solution presented is not the best as it does not fit all business cases.

Really, this improvement does not allow for partial refunds. Please consider. The button should not be visible if 100% of the invoice is Confirmed refunded. What happens if the generated refund invoice is canceled?

[Khushboo Bhatt(openerp) (kbh-openerp)]

Hello Kyle,

Thanks for your reply, but I could not found how can you create the partial refund because If I am trying to create with "refund" button It will always create the same refund as invoice amount.

Have you customized something? please elaborate more.

Thank you!

[qdp (OpenERP) (qdp)]

?
bug set back to 'fix comitted' status as it hasn't been merged in trunk yet. Please (re)read our bug fixing policy if you're confused Giorgio... i also removed the 'public security' flag which had no reason to be.

About this bug, i think like Kyle that it isn't a good solution because it doesn't work for partial refunds... maybe you should check if the invoice is 'paid', and if the related payments are belonging to a refund journal, in order to display or not the button.