_inherit_properties_from_image checks 'arch' instead of 'architecture'

Bug #1082547 reported by Lorin Hochstein
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Chuck Short

Bug Description

In nova/compute/api.py, the _inherit_properties_from_image method appears to be retrieving the 'arch' property from an image to get the architecture (if any) associated with an image:

        options_from_image = {'os_type': prop('os_type'),
                              'architecture': prop('arch'),
                              'vm_mode': prop('vm_mode')}

However, other parts of the code seem to assume that this property is called 'architecture' on the image, not 'arch'. For example, in that same file, the _instance_supported method has:

            # grab the architecture from glance
            architecture = image['properties'].get('architecture', 'Unknown')

and the nova/scheduler/filters/image_props_filter.py:instance_supported method has:

        img_arch = image_props.get('architecture', None)

Changed in nova:
assignee: nobody → Chuck Short (zulcss)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/16976
Committed: http://github.com/openstack/nova/commit/3930b85b9a2dd2aaa2bf006d7f126348ea6b9fdb
Submitter: Jenkins
Branch: master

commit 3930b85b9a2dd2aaa2bf006d7f126348ea6b9fdb
Author: Chuck Short <email address hidden>
Date: Tue Nov 27 09:26:48 2012 -0600

    Fix typo in inherit_properties_from_image

    Should be architecture rather than arch.
    Fixes LP: 1082547

    Change-Id: I9e40b00ec05a99f11894b0e47a9cf47b20b46fe2
    Signed-off-by: Chuck Short <email address hidden>

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.