make_service_package.sh fails on service version number parsing

[Hannu Leinonen]

On current trunk, the version number parsing in make_service_package.sh fails, because the parsed version string might contain a newline.

To verify, see the line 37, where is: SVERSION=`grep version "$SID/metadata.conf" | cut -d '=' -f 2 | tr -d ' '`
On my 64-bit Ubuntu 12.10 machine calling for instance: grep version "data/nuvolaplayer/services/googleplay/metadata.conf" | cut -d '=' -f 2 | tr -d ' '
Returns:
3
10
Where as it should return (I guess):
310

Patch included to remove the possible newlines.

[Jiří Janoušek (fenryxo)]

Actually, the script make_service_package.sh has been rewritten in a
side branch to create packages in the new format for installation via
service selector screen in NP 1.1/2.0, but I forgot to merge the
branch to the trunk.

Anyway, the script is for creation of a service package for Nuvola
Player website[1], what do you need it for?

[1] http://nuvolaplayer.fenryxo.cz/services.html

  status triaged
  importance high
  milestone 2.1.0

[Hannu Leinonen (hleinone)]

Well, I was playing around with the Spotify service creation and wanted to try it on another machine. So I though the script might be easy way to distribute it and noticed the bug.

If the script has already been rewritten and it will be merged to the trunk, this issue and patch are pretty much useless.

[Jiří Janoušek (fenryxo)]

> Well, I was playing around with the Spotify service creation and wanted
> to try it on another machine. So I though the script might be easy way
> to distribute it and noticed the bug.

Fair enough.

> If the script has already been rewritten and it will be merged to the
> trunk, this issue and patch are pretty much useless.

There is no make_service_package.sh compatible with the new API of NP
1.1/2.0, so the issue is pretty valid, not useless.

Fix committed to lp:nuvola-player as r597.

  status fixcommitted

[Jiří Janoušek (fenryxo)]

The fix has been released in a freshly baken Nuvola Player 2.1.0.