nova/network/minidns.py should avoid writing dnstest.txt in local directory
Bug #1081750 reported by
Davanum Srinivas (DIMS)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Davanum Srinivas (DIMS) |
Bug Description
Note from David Ripton in a code review:
David Ripton 11:29 AM
Not a big fan of just dropping dnstest.txt into the current directory then deleting it. There's a chance, albeit small, that the user has a file with that name. And there's also a chance that the current directory is not writable. It would be better to use the tempfile module to created a guaranteed unique filename in a should-be-usable temporary directory.
tags: | added: low-hanging-fruit |
Changed in nova: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in nova: | |
assignee: | nobody → alberto besana (alberto-besana) |
Changed in nova: | |
assignee: | nobody → Davanum Srinivas (dims-v) |
status: | Triaged → In Progress |
Changed in nova: | |
status: | In Progress → Confirmed |
assignee: | Davanum Srinivas (dims-v) → nobody |
Changed in nova: | |
milestone: | none → grizzly-2 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | grizzly-2 → 2013.1 |
To post a comment you must log in.
alberto, i already have a fix in this review - https:/ /review. openstack. org/#/c/ 16535/