minification with bad "requires" param
Bug #1081205 reported by
Thiago Veronezi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-gui |
Fix Released
|
High
|
Benji York | ||
Bug Description
The minification process does not read the "requires" parameters defined in "all-app-debug.js". This parameter should be defined in each custom yui object that uses some kind of internal or external requirement. The sole use of "all-app-debug.js" is to define the fullpath of the file that defines a given module.
This patch removes all the existing "requires" properties from "all-app-debug.js" and add then where they are needed.
Related branches
lp:~tveronezi/juju-gui/change-requires-param
- Juju GUI Hackers: Pending requested
-
Diff: 1823 lines (+808/-847)10 files modifiedapp/app.js (+1/-0)
app/models/charm.js (+2/-1)
app/models/models.js (+1/-0)
app/modules-debug.js (+8/-12)
app/store/charm.js (+1/-0)
test/test_app.js (+176/-191)
test/test_app_hotkeys.js (+52/-52)
test/test_model.js (+18/-25)
test/test_notifications.js (+454/-469)
test/test_notifier_widget.js (+95/-97)
lp:~benji/juju-gui/bug-1081205
- Benji York (community): Approve (code)
-
Diff: 1823 lines (+808/-847)10 files modifiedapp/app.js (+1/-0)
app/models/charm.js (+2/-1)
app/models/models.js (+1/-0)
app/modules-debug.js (+8/-12)
app/store/charm.js (+1/-0)
test/test_app.js (+176/-191)
test/test_app_hotkeys.js (+52/-52)
test/test_model.js (+18/-25)
test/test_notifications.js (+454/-469)
test/test_notifier_widget.js (+95/-97)
| Changed in juju-gui: | |
| assignee: | nobody → Thiago Veronezi (tveronezi) |
| milestone: | none → bluemoon |
| status: | New → In Progress |
Revision history for this message
| Gary Poster (gary) wrote | #1 |
| Changed in juju-gui: | |
| importance: | Undecided → High |
| assignee: | Thiago Veronezi (tveronezi) → Benji York (benji) |
| Changed in juju-gui: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Two tasks to land this branch:
1) Fix failing test.
relation notifications: "should generate messages about one-party relations"
Looks like it is a bad space removal:
expected 'Relation with endpoint1 (relation type "relation1") was created' to equal 'Relation with endpoint1 (relation type"relation1") was created'
Hopefully simple/trivial.
2) Address test changes. Steps to follow:
A) get branch
B) revert all test files to version from start of branch
C) If tests pass in 10 runs, COMMIT and MAKE A RETROSPECTIVE CARD TO DISCUSS SWITCHING TO STANDARD YUI APPROACH
D) if tests fail, revert to branch as is, COMMIT and MAKE THAT RETROSPECTIVE CARD.