Patches sent to patches.l.o aren't tracked

Bug #1081179 reported by Lee Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro patch metrics
Won't Fix
High
Unassigned

Bug Description

When I visit my dashboard I can see that I have around 350 submissions which are still not marked correctly.

Most of these are either duplicates or have been accepted already.

Also, if a patch is submitted with exactly the same $SUBJECT line, I think any previous submissions should be invalidated.

Revision history for this message
Lee Jones (lag) wrote :

For instance:

ARM: ux500: New DT:ed snowball_platform_devs for one-by-one device enablement

Listed here: http://patches.linaro.org/7958/

Is clearly present:
  git log --no-merges --grep="snowball_platform_devs for one-by-one" mainline/master

Revision history for this message
Данило Шеган (danilo) wrote :

The above patch has been merged as
  http://ftp.arm.linux.org.uk/git/gitweb.cgi?p=linux-arm.git;a=commit;h=11a0b5f09c941ede301ed3eee59fd69c2b4850c2

The diffs are not entirely identical: https://pastebin.linaro.org/1089/ (warning, diff of diffs :).

I suppose patchwork can't really match these up as one and the same patch. I'll take a look at a few others and see if there's something simple we can do.

Revision history for this message
Данило Шеган (danilo) wrote :

Ok, this patch was really superseded by http://patches.linaro.org/9019/ which is correctly recognized as 'accepted'.

Changed in linaro-patchmetrics:
milestone: none → 2012.11
Revision history for this message
Данило Шеган (danilo) wrote :

We likely won't get to this in 2012.11, but I am just targeting so we don't forget about it for 2012.12.

Revision history for this message
Lee Jones (lag) wrote :

Sounds good.

On closer inspection, in appears that the vast majority of the accepted patches have been marked as so. Although, this isn't the case for all of them. I'm guessing that if a maintainer fixes-up a patch himself (or herself) then the diffs of the patch sent to patches.linaro.org and the applied one will differ.

The real issue here; however, seems to be the lack of marking patches as invalid as they are superseded by fix-ups. The solution shouldn't be too difficult. If a patch is sent with exactly the same $SUBJECT line and has the same commiter, then any previous patch submissions should be marked as invalid or superseded, perhaps with a link to its successor.

David Zinman (dzinman)
Changed in linaro-patchmetrics:
milestone: 2012.11 → 2012.12
Changed in linaro-patchmetrics:
status: New → Triaged
importance: Undecided → High
assignee: nobody → James Tunnicliffe (dooferlad)
Changed in linaro-patchmetrics:
milestone: 2012.12 → 2013.01
assignee: James Tunnicliffe (dooferlad) → nobody
David Zinman (dzinman)
Changed in linaro-patchmetrics:
assignee: nobody → Данило Шеган (danilo)
milestone: 2013.01 → 2013.02
David Zinman (dzinman)
Changed in linaro-patchmetrics:
milestone: 2013.02 → backlog
Changed in linaro-patchmetrics:
assignee: Данило Шеган (danilo) → nobody
Revision history for this message
Milo Casagrande (milo) wrote :

Due to the age of this issue, we are acknowledging that this issue will likely not be fixed, is no longer applicable, or was already fixed by an indirect change. If this issue is still important, please add details and reopen the issue using http://bugs.linaro.org.

Changed in linaro-patchmetrics:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.