DB migration doesn't seem to handle metadata encryption

Bug #1081043 reported by Stuart McLaren
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Brian Waldon
Grizzly
Fix Released
High
Brian Waldon

Bug Description

As far as I can tell from the code, this function:

'migrate_location_credentials'

in "glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py"
doesn't check to see if the location is encrypted using the metadata_encryption_key parameter.
So if the location is encrypted the new fix_uri_credentials edit won't be applied.

Brian Waldon (bcwaldon)
Changed in glance:
assignee: nobody → Alex Meade (alex-meade)
milestone: none → grizzly-3
Alex Meade (alex-meade)
Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19418

Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → High
Changed in glance:
assignee: Alex Meade (alex-meade) → Brian Waldon (bcwaldon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/19418
Committed: http://github.com/openstack/glance/commit/fad36d8ef79e52d8bf67c89bde876911990abf8f
Submitter: Jenkins
Branch: master

commit fad36d8ef79e52d8bf67c89bde876911990abf8f
Author: Alex Meade <email address hidden>
Date: Thu Jan 10 12:24:02 2013 -0500

    Add migration to quote encrypted image location urls

    Migration 015_quote_swift_credentials.py failed to take into account
    encrypted location values. This patch adds a similar migration
    that if the value is encrypted then:
    1. Decrypts the value
    2. Quotes the url string
    3. Encrypts the value
    4. Inserts back into DB

    fixes bug 1081043

    Change-Id: Iadfe5f5082b3932307eef8e76571e36c6ff9fce7

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.