error in intervals.union_overlapping
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Graphite |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
The function "union_overlapping" in intervals.py only works if the list of intervals is passed in in sorted order.
However, the ceres backend keeps the slice info in reverse sorted order:
ceres.py:251 slice_info.
which causes errors accessing Ceres data - measure_
the attached patch makes the code more robust: it will work regardless of whether the list of intervals is sorted in forward or reverse direction, it is also more readable since it uses the 'overlaps' and 'union' methods of class Interval, rather than comparing start and end times (which is order-dependent)
Thanks, this is a great catch. I've merged this in master: https:/ /github. com/graphite- project/ graphite- web/commit/ df01d98f090c2cd 0c28876f3a409c4 f0f0e1a92f
One question - I'm curious, what branch are you running for carbon to work with Ceres?