Launchpad itself

https://code.launchpad.net/~ broken if the user had worked on private projects but has no longer access to these projects

Bug #1079116 reported by Abel Deuring
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Abel Deuring

Bug Description

From question 214223:

When I try to access https://code.launchpad.net/~cr3, I get: Not allowed here. The reason is probably that I was removed from a bunch of projects recently, some of which were proprietary. If there were some branches related to such projects, I imagine this might be triggering a permission error. Would it be possible to access my code again?

Related branches

lp:~abentley/launchpad/proprietary-person-listing (Merged)
lp:~adeuring/launchpad/bug-1079116
j.c.sackett (community): Approve
Diff: 106 lines (+63/-2)
2 files modified
lib/lp/code/browser/branchlisting.py (+5/-1)
lib/lp/code/browser/tests/test_branchlisting.py (+58/-1)
Abel Deuring (adeuring)
summary: https://code.launchpad.net/~person broken if the person had worked on
- private projects but has no longer access to these pages
+ private projects but has no longer access to these projects
Changed in launchpad:
status: New → Triaged
Abel Deuring (adeuring)
Changed in launchpad:
importance: Undecided → Critical
Revision history for this message
William Grant (wgrant) wrote : Re: https://code.launchpad.net/~person broken if the person had worked on private projects but has no longer access to these projects

This is OOPS-60b35a12067d7c35bfca609215ae4c21

tags: added: 403 fallout private-projects regression
Abel Deuring (adeuring)
summary: - https://code.launchpad.net/~person broken if the person had worked on
+ https://code.launchpad.net/people/+me/ broken if the user had worked on
private projects but has no longer access to these projects
Curtis Hovey (sinzui)
summary: - https://code.launchpad.net/people/+me/ broken if the user had worked on
- private projects but has no longer access to these projects
+ https://code.launchpad.net/~ broken if the user had worked on private
+ projects but has no longer access to these projects
Aaron Bentley (abentley)
Changed in launchpad:
assignee: nobody → Aaron Bentley (abentley)
status: Triaged → In Progress
Revision history for this message
Deryck Hodge (deryck) wrote :

We can't ever get outselves in this shape again with another change we're about to land. So there's nothing really to fix here in our code, at least after the change for bug 1079785 lands. But we do need to fix up Marc's data so his pages are viewable again -- i.e. his branches should become proprietary to match the product information type. I'll take on fixing this tomorrow for him.

Changed in launchpad:
assignee: Aaron Bentley (abentley) → Deryck Hodge (deryck)
importance: Critical → High
tags: removed: fallout regression
Revision history for this message
William Grant (wgrant) wrote :

The problematic branch is already proprietary, and I don't think any of the in-progress work will fix this. The issue is that he has an AAG on the branch, but apparently you're not allowed to see a productseries without an APG on its product.

Changed in launchpad:
importance: High → Critical
Curtis Hovey (sinzui)
tags: added: regression
Revision history for this message
Deryck Hodge (deryck) wrote :

Ah, thanks for the extra info, William. Indeed, that's not fixed by anything in progress. Abel will look into this today.

Changed in launchpad:
assignee: Deryck Hodge (deryck) → Abel Deuring (adeuring)
tags: added: fallout
Revision history for this message
Abel Deuring (adeuring) wrote :

Marc, could you try to access the page again, preferably at a time both you and me are available on IRC? Unfortunately, the OOPS report has been deleted and I have difficulties to create a test setup to reproduce the bug. Having a new OOPS report might give me again a clue.

Revision history for this message
Abel Deuring (adeuring) wrote :

I talked with Marc; he can meanwhile access the page. The problem he had may have been related to bugs fixed in r16273

Changed in launchpad:
status: In Progress → Fix Released
Revision history for this message
William Grant (wgrant) wrote :

cr3's case is fixed because the productseries is no longer linked to that branch. The 403 on Person:+code-index is still reproducible if you set up the same scenario: a user owning and with a grant for a series branch, but with no grant for the proprietary project.

Changed in launchpad:
status: Fix Released → Triaged
Curtis Hovey (sinzui)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r16325 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16325>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Abel Deuring (adeuring)
tags: added: qa-ok
removed: qa-needstesting
Richard Harding (rharding)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.