swift-init should check if binary exists before starting

[Christian Berendt]

At the moment swift-init simply tries start up all defined services and fails, because some configuration files are not existent.

Unable to locate config for proxy-server
Starting container-replicator...(/etc/swift/container-server.conf)
Starting object-auditor...(/etc/swift/object-server.conf)
Unable to locate config for object-expirer

I think swift-init should check if the needed binary (for example swift-proxy-server) exists on the system before proceeding.

[clayg (clay-gerrard)]

It seems like the simplest thing would be to check for the bin (something like distutils.spawn.find_executable) when adding the Server's to the Manager.

For clarity, it seems like this applies to status, and stop as much as start. And the bug seems to be the printing of the warning "Unable to locate config for X-server" as it doesn't seem to effect the successful return code when you're starting multiple servers.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/91753

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Dickinson (<email address hidden>) on branch: master
Review: https://review.openstack.org/91753
Reason: Abandoning due to lack of activity since the last negative review. You can restore the change if you want to keep working on it.

[Jiri Suchomel (jsuchome)]

The proposed patch tries to handle the situation with missing binaries, but not with the config files, mentioned in the report.

[Harshit (harshit-3)]

I am new to this process.
How do I proceed with fixing the bug?

[clayg (clay-gerrard)]

Hrmm.... I think maybe this is best page for that:

https://wiki.openstack.org/wiki/Gerrit_Workflow#Gerrit_Workflow_Quick_Reference

[Harshit (harshit-3)]

Thanks for the response clayg.

I have addressed the comments, but the change is abandoned. So should i push it as a new changeset or can someone un-abandon the changeset .

[Madhuri Kumari (madhuri-rai07)]

Hi harshit,
Thanks for your contribution.

I am in progress of fixing this bug. Review https://review.openstack.org/#/c/91753/ was being released for fix. I am continuing this work.

[Mohit Motiani (mohit-motiani)]

Hi Madhuri,

Are you still woking on this bug?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Madhuri Kumari (<email address hidden>) on branch: master
Review: https://review.openstack.org/91753

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/swift 2.27.0 release.