Unit Test to create instance without config driver is wrong

Bug #1078737 reported by Mauro S M Rodrigues
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Mauro S M Rodrigues

Bug Description

The Test without config drive is exactly the same as the one with config drive so this is not being tested

Without config drive: https://github.com/openstack/nova/blob/master/nova/tests/api/openstack/compute/test_servers.py#L2775
with config drive: https://github.com/openstack/nova/blob/master/nova/tests/api/openstack/compute/test_servers.py#L2695

I believe that to fix it I just need to remove the line that specifies the config drive leaving the extension activated.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16083

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/16083
Committed: http://github.com/openstack/nova/commit/c01589c22a07a179689e5d7b7cc3f27bec5393cb
Submitter: Jenkins
Branch: master

commit c01589c22a07a179689e5d7b7cc3f27bec5393cb
Author: Mauro S. M. Rodrigues <email address hidden>
Date: Wed Nov 14 09:17:33 2012 -0500

    Fixes create instance *without* config drive test

    Fixes bug 1078737

    Change-Id: Id6e84da45b58a1a449045933823eb98e022df088

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.